Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top (Closed)
Patch Set: fix compile and dchecks Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999-2001 Lars Knoll <knoll@kde.org> 3 * 1999-2001 Lars Knoll <knoll@kde.org>
4 * 1999-2001 Antti Koivisto <koivisto@kde.org> 4 * 1999-2001 Antti Koivisto <koivisto@kde.org>
5 * 2000-2001 Simon Hausmann <hausmann@kde.org> 5 * 2000-2001 Simon Hausmann <hausmann@kde.org>
6 * 2000-2001 Dirk Mueller <mueller@kde.org> 6 * 2000-2001 Dirk Mueller <mueller@kde.org>
7 * 2000 Stefan Schimanski <1Stein@gmx.de> 7 * 2000 Stefan Schimanski <1Stein@gmx.de>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
9 * reserved. 9 * reserved.
10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 FrameSelection& Selection() const; 147 FrameSelection& Selection() const;
148 InputMethodController& GetInputMethodController() const; 148 InputMethodController& GetInputMethodController() const;
149 ScriptController& GetScriptController() const; 149 ScriptController& GetScriptController() const;
150 SpellChecker& GetSpellChecker() const; 150 SpellChecker& GetSpellChecker() const;
151 FrameConsole& Console() const; 151 FrameConsole& Console() const;
152 152
153 // This method is used to get the highest level LocalFrame in this 153 // This method is used to get the highest level LocalFrame in this
154 // frame's in-process subtree. 154 // frame's in-process subtree.
155 // FIXME: This is a temporary hack to support RemoteFrames, and callers 155 // FIXME: This is a temporary hack to support RemoteFrames, and callers
156 // should be updated to avoid storing things on the main frame. 156 // should be updated to avoid storing things on the main frame.
157 LocalFrame* LocalFrameRoot(); 157 LocalFrame& LocalFrameRoot() const;
158 158
159 // Note that the result of this function should not be cached: a frame is 159 // Note that the result of this function should not be cached: a frame is
160 // not necessarily detached when it is navigated, so the return value can 160 // not necessarily detached when it is navigated, so the return value can
161 // change. 161 // change.
162 // In addition, this function will always return true for a detached frame. 162 // In addition, this function will always return true for a detached frame.
163 // TODO(dcheng): Move this to LocalDOMWindow and figure out the right 163 // TODO(dcheng): Move this to LocalDOMWindow and figure out the right
164 // behavior for detached windows. 164 // behavior for detached windows.
165 bool IsCrossOriginSubframe() const; 165 bool IsCrossOriginSubframe() const;
166 166
167 CoreProbeSink* InstrumentingAgents() { return instrumenting_agents_.Get(); } 167 CoreProbeSink* InstrumentingAgents() { return instrumenting_agents_.Get(); }
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 explicit ScopedFrameBlamer(LocalFrame*); 377 explicit ScopedFrameBlamer(LocalFrame*);
378 ~ScopedFrameBlamer(); 378 ~ScopedFrameBlamer();
379 379
380 private: 380 private:
381 Member<LocalFrame> frame_; 381 Member<LocalFrame> frame_;
382 }; 382 };
383 383
384 } // namespace blink 384 } // namespace blink
385 385
386 #endif // LocalFrame_h 386 #endif // LocalFrame_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp ('k') | third_party/WebKit/Source/core/frame/LocalFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698