Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp

Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top (Closed)
Patch Set: fix compile and dchecks Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
diff --git a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
index 149aafe389f4902a673add705d572954b4eb0517..29d711f1319fa2d32ab68d7a400b5855bc662156 100644
--- a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
+++ b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
@@ -73,9 +73,8 @@ namespace blink {
namespace {
-int FrameId(LocalFrame* frame) {
- ASSERT(frame);
- return WeakIdentifierMap<LocalFrame>::Identifier(frame);
+int FrameId(LocalFrame& frame) {
+ return WeakIdentifierMap<LocalFrame>::Identifier(&frame);
}
Mutex& CreationMutex() {
@@ -215,7 +214,7 @@ void MainThreadDebugger::ExceptionThrown(ExecutionContext* context,
}
int MainThreadDebugger::ContextGroupId(LocalFrame* frame) {
- LocalFrame* local_frame_root = frame->LocalFrameRoot();
+ LocalFrame& local_frame_root = frame->LocalFrameRoot();
return FrameId(local_frame_root);
}

Powered by Google App Engine
This is Rietveld 408576698