third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp - Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top (Closed)

Patch Set: fix compile and dchecks Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

index 6d8352e8a9ce583a03b426daf72da614db504e39..fbdd9e40a89379a5cb5d9643c920a767642e1de6 100644

--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

@@ -1637,7 +1637,7 @@ DOMWindow* LocalDOMWindow::open(const String& url_string,

// In those cases, we schedule a location change right now and return early.

Frame* target_frame = nullptr;

if (EqualIgnoringASCIICase(frame_name, "_top")) {

- target_frame = GetFrame()->Tree().Top();

+ target_frame = &GetFrame()->Tree().Top();

} else if (EqualIgnoringASCIICase(frame_name, "_parent")) {

if (Frame* parent = GetFrame()->Tree().Parent())

target_frame = parent;