third_party/WebKit/Source/core/frame/Deprecation.cpp - Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top (Closed)

Patch Set: fix compile and dchecks Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/Deprecation.cpp

diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp

index a2fdb48282e6db259159bf6b3fdbb172f765fa01..725b5afe7ad21b4590ef4f8311a7655751744fff 100644

--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp

+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp

@@ -161,9 +161,9 @@ void Deprecation::CountDeprecationCrossOriginIframe(

// Check to see if the frame can script into the top level document.

SecurityOrigin* security_origin =

frame->GetSecurityContext()->GetSecurityOrigin();

- Frame* top = frame->Tree().Top();

- if (top && !security_origin->CanAccess(

- top->GetSecurityContext()->GetSecurityOrigin()))

+ Frame& top = frame->Tree().Top();

+ if (!security_origin->CanAccess(

+ top.GetSecurityContext()->GetSecurityOrigin()))

CountDeprecation(frame, feature);

}