Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top (Closed)
Patch Set: fix compile and dchecks Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 1030 matching lines...) Expand 10 before | Expand all | Expand 10 after
1041 DEFINE_TRACE(FrameSelection) { 1041 DEFINE_TRACE(FrameSelection) {
1042 visitor->Trace(frame_); 1042 visitor->Trace(frame_);
1043 visitor->Trace(layout_selection_); 1043 visitor->Trace(layout_selection_);
1044 visitor->Trace(selection_editor_); 1044 visitor->Trace(selection_editor_);
1045 visitor->Trace(frame_caret_); 1045 visitor->Trace(frame_caret_);
1046 SynchronousMutationObserver::Trace(visitor); 1046 SynchronousMutationObserver::Trace(visitor);
1047 } 1047 }
1048 1048
1049 void FrameSelection::ScheduleVisualUpdate() const { 1049 void FrameSelection::ScheduleVisualUpdate() const {
1050 if (Page* page = frame_->GetPage()) 1050 if (Page* page = frame_->GetPage())
1051 page->Animator().ScheduleVisualUpdate(frame_->LocalFrameRoot()); 1051 page->Animator().ScheduleVisualUpdate(&frame_->LocalFrameRoot());
1052 } 1052 }
1053 1053
1054 void FrameSelection::ScheduleVisualUpdateForPaintInvalidationIfNeeded() const { 1054 void FrameSelection::ScheduleVisualUpdateForPaintInvalidationIfNeeded() const {
1055 if (FrameView* frame_view = frame_->View()) 1055 if (FrameView* frame_view = frame_->View())
1056 frame_view->ScheduleVisualUpdateForPaintInvalidationIfNeeded(); 1056 frame_view->ScheduleVisualUpdateForPaintInvalidationIfNeeded();
1057 } 1057 }
1058 1058
1059 bool FrameSelection::SelectWordAroundPosition(const VisiblePosition& position) { 1059 bool FrameSelection::SelectWordAroundPosition(const VisiblePosition& position) {
1060 static const EWordSide kWordSideList[2] = {kRightWordIfOnBoundary, 1060 static const EWordSide kWordSideList[2] = {kRightWordIfOnBoundary,
1061 kLeftWordIfOnBoundary}; 1061 kLeftWordIfOnBoundary};
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
1180 } 1180 }
1181 1181
1182 void showTree(const blink::FrameSelection* sel) { 1182 void showTree(const blink::FrameSelection* sel) {
1183 if (sel) 1183 if (sel)
1184 sel->ShowTreeForThis(); 1184 sel->ShowTreeForThis();
1185 else 1185 else
1186 LOG(INFO) << "Cannot showTree for <null> FrameSelection."; 1186 LOG(INFO) << "Cannot showTree for <null> FrameSelection.";
1187 } 1187 }
1188 1188
1189 #endif 1189 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/IntersectionObservation.cpp ('k') | third_party/WebKit/Source/core/frame/DOMWindow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698