third_party/WebKit/Source/core/page/ChromeClient.cpp - Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/ChromeClient.cpp

Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top (Closed)

Patch Set: fix compile and dchecks Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/ChromeClient.cpp

diff --git a/third_party/WebKit/Source/core/page/ChromeClient.cpp b/third_party/WebKit/Source/core/page/ChromeClient.cpp

index 972b1dbc7adcffe79706ed637a0056225b4a55b5..a7c4ea868efbf805f6c00a50f6c8e5cf9fadac22 100644

--- a/third_party/WebKit/Source/core/page/ChromeClient.cpp

+++ b/third_party/WebKit/Source/core/page/ChromeClient.cpp

@@ -67,10 +67,11 @@ void ChromeClient::SetWindowRectWithAdjustment(const IntRect& pending_rect,

}

bool ChromeClient::CanOpenModalIfDuringPageDismissal(

- Frame* main_frame,

+ Frame& main_frame,

ChromeClient::DialogType dialog,

const String& message) {

- for (Frame* frame = main_frame; frame; frame = frame->Tree().TraverseNext()) {

+ for (Frame* frame = &main_frame; frame;

+ frame = frame->Tree().TraverseNext()) {

if (!frame->IsLocalFrame())

continue;

LocalFrame& local_frame = ToLocalFrame(*frame);