third_party/WebKit/Source/core/frame/LocalFrame.h - Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top (Closed)

Patch Set: fix compile and dchecks Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalFrame.h

diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.h b/third_party/WebKit/Source/core/frame/LocalFrame.h

index d6e5d1829d8d4b721fe8baf6ef01225ef17c74a1..746f4f20cad44591f02c4263beaed3a7ff058c9b 100644

--- a/third_party/WebKit/Source/core/frame/LocalFrame.h

+++ b/third_party/WebKit/Source/core/frame/LocalFrame.h

@@ -154,7 +154,7 @@ class CORE_EXPORT LocalFrame final : public Frame,

// frame's in-process subtree.

// FIXME: This is a temporary hack to support RemoteFrames, and callers

// should be updated to avoid storing things on the main frame.

- LocalFrame* LocalFrameRoot();

+ LocalFrame& LocalFrameRoot() const;

// Note that the result of this function should not be cached: a frame is

// not necessarily detached when it is navigated, so the return value can