third_party/WebKit/Source/core/page/FrameTree.h - Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/FrameTree.h

Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top (Closed)

Patch Set: fix compile and dchecks Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/FrameTree.h

diff --git a/third_party/WebKit/Source/core/page/FrameTree.h b/third_party/WebKit/Source/core/page/FrameTree.h

index 9e8854c796ae9479b39f2ec8e3433ef6e998e33c..07ab2368de008f8a4cea3db17180b4ca730c4ecd 100644

--- a/third_party/WebKit/Source/core/page/FrameTree.h

+++ b/third_party/WebKit/Source/core/page/FrameTree.h

@@ -43,7 +43,7 @@ class CORE_EXPORT FrameTree final {

void ExperimentalSetNulledName();

Frame* Parent() const;

- Frame* Top() const;

+ Frame& Top() const;

Frame* NextSibling() const;

Frame* FirstChild() const;