Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2785523003: PaymentHandler: Rename PaymentAppManager to PaymentManager. (Closed)

Created:
3 years, 8 months ago by zino
Modified:
3 years, 8 months ago
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, gogerald+paymentswatch_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, rouslan+payments_chromium.org, blink-reviews, darin-cc_chromium.org, mahmadi+paymentswatch_chromium.org, darin (slow to review), sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : PaymentHandler: Rename PaymentAppManager to PaymentManager. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -912 lines) Patch
M components/payments/content/payment_app.mojom View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/payments/payment_app_content_unittest_base.h View 1 2 3 3 chunks +8 lines, -8 lines 0 comments Download
M content/browser/payments/payment_app_content_unittest_base.cc View 1 2 3 3 chunks +18 lines, -18 lines 0 comments Download
M content/browser/payments/payment_app_context_impl.h View 5 chunks +13 lines, -14 lines 0 comments Download
M content/browser/payments/payment_app_context_impl.cc View 3 chunks +14 lines, -15 lines 0 comments Download
D content/browser/payments/payment_app_manager.h View 1 chunk +0 lines, -53 lines 0 comments Download
D content/browser/payments/payment_app_manager.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D content/browser/payments/payment_app_manager_unittest.cc View 1 chunk +0 lines, -124 lines 0 comments Download
M content/browser/payments/payment_app_provider_impl_unittest.cc View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
A + content/browser/payments/payment_manager.h View 3 chunks +13 lines, -13 lines 0 comments Download
A + content/browser/payments/payment_manager.cc View 4 chunks +10 lines, -11 lines 0 comments Download
A + content/browser/payments/payment_manager_unittest.cc View 4 chunks +19 lines, -19 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/payments/payment_app_invocation.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/payments/payment-app-interfaces.html View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/payments/payment-app-manager.html View 1 2 3 1 chunk +0 lines, -219 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/payments/payment-manager.html View 1 2 3 8 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/payments/resources/payment-app.js View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/navigation-preload-origin-trial-interfaces-expected.txt View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/chromium/navigation-preload-origin-trial-interfaces-expected.txt View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/chromium/navigation-preload-origin-trial-interfaces-expected.txt View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/modules/payments/PaymentAppManager.h View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp View 1 chunk +0 lines, -200 lines 0 comments Download
D third_party/WebKit/Source/modules/payments/PaymentAppManager.idl View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAppServiceWorkerRegistration.h View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAppServiceWorkerRegistration.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAppServiceWorkerRegistration.idl View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/modules/payments/PaymentManager.h View 4 chunks +9 lines, -9 lines 0 comments Download
A + third_party/WebKit/Source/modules/payments/PaymentManager.cpp View 6 chunks +14 lines, -15 lines 0 comments Download
A + third_party/WebKit/Source/modules/payments/PaymentManager.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
zino
PTAL
3 years, 8 months ago (2017-03-29 15:41:21 UTC) #3
zino
On 2017/03/29 15:41:21, zino wrote: > PTAL rouslan@ for payments Tom Sepez@ for mojom Avi@ ...
3 years, 8 months ago (2017-03-29 15:42:02 UTC) #4
Avi (use Gerrit)
LGTM stampity stamp
3 years, 8 months ago (2017-03-29 15:46:59 UTC) #5
Tom Sepez
LGTM stampity stampity stamp
3 years, 8 months ago (2017-03-29 19:54:02 UTC) #6
haraken
LGTM
3 years, 8 months ago (2017-03-29 23:20:44 UTC) #7
zino
rouslan@ gentle ping. This is just a rename patch. This CL is initiated from your ...
3 years, 8 months ago (2017-03-30 00:18:17 UTC) #8
please use gerrit instead
lgtm
3 years, 8 months ago (2017-03-30 01:10:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785523003/40001
3 years, 8 months ago (2017-03-30 10:53:15 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/411650)
3 years, 8 months ago (2017-03-30 12:40:44 UTC) #14
zino
On 2017/03/30 12:40:44, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 8 months ago (2017-03-30 12:56:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785523003/60001
3 years, 8 months ago (2017-03-30 12:57:02 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 15:10:47 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bbb00c3bef1374d4590acaa8ed59...

Powered by Google App Engine
This is Rietveld 408576698