third_party/WebKit/Source/modules/payments/PaymentAppManager.idl - Issue 2775343002: PaymentHandler: Initial implementation for PaymentInstruments.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/payments/PaymentAppManager.idl

Issue 2775343002: PaymentHandler: Initial implementation for PaymentInstruments. (Closed)

Patch Set: PaymentHandler: Initial implementation for PaymentInstruments. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp ('k') | third_party/WebKit/Source/modules/payments/PaymentInstrument.idl » ('j') | third_party/WebKit/Source/modules/payments/PaymentInstrument.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentappmanager	5 // https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentappmanager

6	6

7 [	7 [

8 RuntimeEnabled=PaymentApp,	8 RuntimeEnabled=PaymentApp,

9 ConstructorCallWith=ExecutionContext,	9 ConstructorCallWith=ExecutionContext,

10 DependentLifetime,	10 DependentLifetime,

11 ] interface PaymentAppManager {	11 ] interface PaymentAppManager {

12 [CallWith=ScriptState] Promise<void> setManifest(PaymentAppManifest manifest );	12 [CallWith=ScriptState] Promise<void> setManifest(PaymentAppManifest manifest );

13 [CallWith=ScriptState] Promise<PaymentAppManifest> getManifest();	13 [CallWith=ScriptState] Promise<PaymentAppManifest> getManifest();

	14 readonly attribute PaymentInstruments instruments;
	please use gerrit instead 2017/03/28 16:33:29 Can you put this into PaymentManager interface ins Can you put this into PaymentManager interface instead? That would match https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentmanager better. zino 2017/03/29 15:51:23 I uploaded another CL: https://codereview.chromium Show quoted text On 2017/03/28 16:33:29, ಠ_ಠ wrote: > Can you put this into PaymentManager interface instead? That would match > https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentmanager > better. I uploaded another CL: https://codereview.chromium.org/2785523003/
14 };	15 };

OLD	NEW