Changed EPosition to an enum class and renamed its members

Changed EPosition to an enum class and renamed its members

Changed EPosition to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EPosition to be used by generated
fields in ComputedStyleBase.

BUG=684966
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2667493002
Cr-Commit-Position: refs/heads/master@{#450202}
Committed: https://chromium.googlesource.com/chromium/src/+/30aef3be9b857563cfab70278e011dba9d1e8a14

[shend, 2017-01-30 02:45:33]

Description was changed from

==========
Changed EPosition to an enum class and renamed its members

Changed EPosition to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EPosition to be used by generated
fields in ComputedStyleBase.

BUG=684966
==========

to

==========
Changed EPosition to an enum class and renamed its members

Changed EPosition to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EPosition to be used by generated
fields in ComputedStyleBase.

BUG=684966
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[shend, 2017-01-31 02:19:06]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 02:19:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 02:22:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 02:22:36]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[shend, 2017-01-31 03:34:08]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 03:34:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 03:36:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 03:36:39]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[shend, 2017-01-31 03:46:45]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 03:47:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 03:49:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 03:49:07]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[shend, 2017-01-31 04:22:58]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-01-31 04:22:59]

Hi Naina, big rename patch, PTAL. Apologies in advance :P

[nainar, 2017-01-31 04:24:17]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 04:24:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-01-31 04:32:02]

On 2017/01/31 at 04:22:59, shend wrote:
> Hi Naina, big rename patch, PTAL. Apologies in advance :P

lgtm. Were the ASSERT -> DCHECK changes were due to git cl format?

[shend, 2017-01-31 04:33:20]

On 2017/01/31 at 04:32:02, nainar wrote:
> On 2017/01/31 at 04:22:59, shend wrote:
> > Hi Naina, big rename patch, PTAL. Apologies in advance :P
> 
> lgtm. Were the ASSERT -> DCHECK changes were due to git cl format?

It was due to the presubmit checks. It complained that ASSERT was deprecated and
told me to use DCHECK.

[shend, 2017-01-31 04:35:25]

shend@chromium.org changed reviewers:
+ sashab@chromium.org

[shend, 2017-01-31 04:35:26]

Sasha PTAL :)

[shend, 2017-01-31 04:49:35]

The CQ bit was unchecked by shend@chromium.org

[sashab, 2017-01-31 19:39:59]

LGTM! New names are so much cooler thx

[shend, 2017-01-31 21:24:48]

The CQ bit was checked by shend@chromium.org

[shend, 2017-01-31 21:24:49]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org,
sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2667493002/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-31 21:25:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 21:25:14]

This CL has an open dependency (Issue 2667533002 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[shend, 2017-02-13 05:15:45]

The CQ bit was checked by shend@chromium.org

[shend, 2017-02-13 05:15:46]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org,
sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2667493002/#ps160001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-13 05:16:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 05:23:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 05:23:26]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[shend, 2017-02-13 22:06:27]

shend@chromium.org changed reviewers:
+ dcheng@chromium.org

[shend, 2017-02-13 22:06:28]

+dcheng for web/ PTAL

[dcheng, 2017-02-13 23:15:25]

rs lgtm for web

[shend, 2017-02-13 23:48:46]

The CQ bit was checked by shend@chromium.org

[shend, 2017-02-13 23:48:47]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org,
sashab@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2667493002/#ps180001
(title: "Rebas")

[commit-bot: I haz the power, 2017-02-13 23:49:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-02-13 23:56:24]

The CQ bit was unchecked by shend@chromium.org

[shend, 2017-02-14 00:02:01]

The CQ bit was checked by shend@chromium.org

[shend, 2017-02-14 00:02:01]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org,
sashab@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2667493002/#ps200001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-14 00:03:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 02:20:12]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1487030521132160,
"parent_rev": "22b31729529579fea43962f4bd0d20a760d027f5", "commit_rev":
"30aef3be9b857563cfab70278e011dba9d1e8a14"}

[commit-bot: I haz the power, 2017-02-14 02:20:52]

Description was changed from

==========
Changed EPosition to an enum class and renamed its members

Changed EPosition to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EPosition to be used by generated
fields in ComputedStyleBase.

BUG=684966
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Changed EPosition to an enum class and renamed its members

Changed EPosition to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EPosition to be used by generated
fields in ComputedStyleBase.

BUG=684966
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2667493002
Cr-Commit-Position: refs/heads/master@{#450202}
Committed:
https://chromium.googlesource.com/chromium/src/+/30aef3be9b857563cfab70278e01...
==========

[commit-bot: I haz the power, 2017-02-14 02:20:54]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/30aef3be9b857563cfab70278e01...