Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2667493002: Changed EPosition to an enum class and renamed its members (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 92cd329996f7e78c48dfedbab0a716d2f80c4dcf..9536d822238abb759a9697c59c699c396b7b94a9 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -1954,7 +1954,7 @@ void FrameView::updateLayersAndCompositingAfterScrollIfNeeded() {
for (const auto& viewportConstrainedObject : *m_viewportConstrainedObjects) {
LayoutObject* layoutObject = viewportConstrainedObject;
PaintLayer* layer = toLayoutBoxModelObject(layoutObject)->layer();
- if (layoutObject->style()->position() == StickyPosition) {
+ if (layoutObject->style()->position() == EPosition::kSticky) {
// TODO(skobes): Resolve circular dependency between scroll offset and
// compositing state, and remove this disabler. https://crbug.com/420741
DisableCompositingQueryAsserts disabler;
@@ -4920,8 +4920,8 @@ bool FrameView::hasVisibleSlowRepaintViewportConstrainedObjects() const {
for (const LayoutObject* layoutObject : *viewportConstrainedObjects()) {
DCHECK(layoutObject->isBoxModelObject() && layoutObject->hasLayer());
- DCHECK(layoutObject->style()->position() == FixedPosition ||
- layoutObject->style()->position() == StickyPosition);
+ DCHECK(layoutObject->style()->position() == EPosition::kFixed ||
+ layoutObject->style()->position() == EPosition::kSticky);
PaintLayer* layer = toLayoutBoxModelObject(layoutObject)->layer();
// Whether the Layer sticks to the viewport is a tree-depenent

Powered by Google App Engine
This is Rietveld 408576698