Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

Issue 2667493002: Changed EPosition to an enum class and renamed its members (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2014 Google Inc. All rights reserved. 3 * Copyright (C) 2014 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 subtreeReasons |= CompositingReasonIsolateCompositedDescendants; 183 subtreeReasons |= CompositingReasonIsolateCompositedDescendants;
184 } 184 }
185 185
186 // FIXME: This should move into 186 // FIXME: This should move into
187 // CompositingReasonFinder::potentialCompositingReasonsFromStyle, but theres 187 // CompositingReasonFinder::potentialCompositingReasonsFromStyle, but theres
188 // a poor interaction with LayoutTextControlSingleLine, which sets this 188 // a poor interaction with LayoutTextControlSingleLine, which sets this
189 // hasOverflowClip directly. 189 // hasOverflowClip directly.
190 if (layer->layoutObject()->hasClipRelatedProperty()) 190 if (layer->layoutObject()->hasClipRelatedProperty())
191 subtreeReasons |= CompositingReasonClipsCompositingDescendants; 191 subtreeReasons |= CompositingReasonClipsCompositingDescendants;
192 192
193 if (layer->layoutObject()->style()->position() == FixedPosition) 193 if (layer->layoutObject()->style()->position() == EPosition::kFixed)
194 subtreeReasons |= CompositingReasonPositionFixedWithCompositedDescendants; 194 subtreeReasons |= CompositingReasonPositionFixedWithCompositedDescendants;
195 } 195 }
196 196
197 // A layer with preserve-3d or perspective only needs to be composited if 197 // A layer with preserve-3d or perspective only needs to be composited if
198 // there are descendant layers that will be affected by the preserve-3d or 198 // there are descendant layers that will be affected by the preserve-3d or
199 // perspective. 199 // perspective.
200 if (has3DTransformedDescendants) { 200 if (has3DTransformedDescendants) {
201 subtreeReasons |= layer->potentialCompositingReasonsFromStyle() & 201 subtreeReasons |= layer->potentialCompositingReasonsFromStyle() &
202 CompositingReasonCombo3DDescendants; 202 CompositingReasonCombo3DDescendants;
203 } 203 }
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
538 descendantHas3DTransform |= 538 descendantHas3DTransform |=
539 anyDescendantHas3DTransform || layer->has3DTransform(); 539 anyDescendantHas3DTransform || layer->has3DTransform();
540 } 540 }
541 541
542 // At this point we have finished collecting all reasons to composite this 542 // At this point we have finished collecting all reasons to composite this
543 // layer. 543 // layer.
544 layer->setCompositingReasons(reasonsToComposite); 544 layer->setCompositingReasons(reasonsToComposite);
545 } 545 }
546 546
547 } // namespace blink 547 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698