third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp - Issue 2667493002: Changed EPosition to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

Issue 2667493002: Changed EPosition to an enum class and renamed its members (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

index 9ed2189a7b4a6638706a3a658a8a2bc531ac13d6..92b93ede5558f7ae7b2706123227a683fa50e9b6 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

@@ -30,7 +30,7 @@ static const PaintLayer* findParentLayerOnClippingContainerChain(

const PaintLayer* layer) {

LayoutObject* current = layer->layoutObject();

while (current) {

- if (current->style()->position() == FixedPosition) {

+ if (current->style()->position() == EPosition::kFixed) {

for (current = current->parent();

current && !current->canContainFixedPositionObjects();

current = current->parent()) {

@@ -101,7 +101,7 @@ void CompositingInputsUpdater::updateRecursive(PaintLayer* layer,

const PaintLayer* previousOverflowLayer = layer->ancestorOverflowLayer();

layer->updateAncestorOverflowLayer(info.lastOverflowClipLayer);

if (info.lastOverflowClipLayer && layer->needsCompositingInputsUpdate() &&

- layer->layoutObject()->style()->position() == StickyPosition) {

+ layer->layoutObject()->style()->position() == EPosition::kSticky) {

if (info.lastOverflowClipLayer != previousOverflowLayer &&

!RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {

// Old ancestor scroller should no longer have these constraints.

@@ -176,7 +176,7 @@ void CompositingInputsUpdater::updateRecursive(PaintLayer* layer,

? parent

: parent->filterAncestor();

bool layerIsFixedPosition =

- layer->layoutObject()->style()->position() == FixedPosition;

+ layer->layoutObject()->style()->position() == EPosition::kFixed;

properties.nearestFixedPositionLayer =

layerIsFixedPosition ? layer : parent->nearestFixedPositionLayer();