third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp - Issue 2667493002: Changed EPosition to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

Issue 2667493002: Changed EPosition to an enum class and renamed its members (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

index 51f4310bb7d0c5726faced2e596bd5a8b27d9088..e6b4a2d2fbccebabffc1f04741613a76f531e207 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

@@ -200,8 +200,8 @@ bool CompositingReasonFinder::requiresCompositingForTransformAnimation(

bool CompositingReasonFinder::requiresCompositingForScrollDependentPosition(

const PaintLayer* layer) const {

- if (layer->layoutObject()->style()->position() != FixedPosition &&

- layer->layoutObject()->style()->position() != StickyPosition)

+ if (layer->layoutObject()->style()->position() != EPosition::kFixed &&

+ layer->layoutObject()->style()->position() != EPosition::kSticky)

return false;

if (!(m_compositingTriggers & ViewportConstrainedPositionedTrigger) &&

@@ -216,7 +216,7 @@ bool CompositingReasonFinder::requiresCompositingForScrollDependentPosition(

// container rather than the enclosing frame.

if (layer->sticksToViewport())

return m_layoutView.frameView()->isScrollable();

- return layer->layoutObject()->style()->position() == StickyPosition &&

+ return layer->layoutObject()->style()->position() == EPosition::kSticky &&

layer->ancestorOverflowLayer()->scrollsOverflow();

}