Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 2667493002: Changed EPosition to an enum class and renamed its members (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
index b0755de97eb432595878d3979350ce6e5b0dde45..bf4faf4eff447320bad99429f6ec2a72e5b5e13d 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
@@ -330,8 +330,8 @@ void PaintLayer::dirtyAncestorChainHasSelfPaintingLayerDescendantStatus() {
}
bool PaintLayer::sticksToViewport() const {
- if (layoutObject()->style()->position() != FixedPosition &&
- layoutObject()->style()->position() != StickyPosition)
+ if (layoutObject()->style()->position() != EPosition::kFixed &&
+ layoutObject()->style()->position() != EPosition::kSticky)
return false;
// TODO(pdr): This approach of calculating the nearest scroll node is O(n).
@@ -340,7 +340,7 @@ bool PaintLayer::sticksToViewport() const {
if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
const auto* viewProperties = layoutObject()->view()->paintProperties();
const ScrollPaintPropertyNode* ancestorTargetScrollNode;
- if (layoutObject()->style()->position() == FixedPosition) {
+ if (layoutObject()->style()->position() == EPosition::kFixed) {
ancestorTargetScrollNode = viewProperties->localBorderBoxProperties()
->transform()
->findEnclosingScrollNode();
@@ -355,10 +355,10 @@ bool PaintLayer::sticksToViewport() const {
return transform->findEnclosingScrollNode() == ancestorTargetScrollNode;
}
- return (layoutObject()->style()->position() == FixedPosition &&
+ return (layoutObject()->style()->position() == EPosition::kFixed &&
layoutObject()->containerForFixedPosition() ==
layoutObject()->view()) ||
- (layoutObject()->style()->position() == StickyPosition &&
+ (layoutObject()->style()->position() == EPosition::kSticky &&
(!ancestorScrollingLayer() || ancestorScrollingLayer() == root()));
}
@@ -2685,7 +2685,7 @@ bool PaintLayer::paintsWithTransform(GlobalPaintFlags globalPaintFlags) const {
}
return (transform() ||
- layoutObject()->style()->position() == FixedPosition) &&
+ layoutObject()->style()->position() == EPosition::kFixed) &&
((globalPaintFlags & GlobalPaintFlattenCompositingLayers) ||
compositingState() != PaintsIntoOwnBacking);
}
@@ -2718,7 +2718,7 @@ bool PaintLayer::backgroundIsKnownToBeOpaqueInRect(
return false;
if (!RuntimeEnabledFeatures::compositeOpaqueFixedPositionEnabled() &&
- layoutObject()->style()->position() == FixedPosition &&
+ layoutObject()->style()->position() == EPosition::kFixed &&
compositingState() != PaintsIntoOwnBacking)
return false;

Powered by Google App Engine
This is Rietveld 408576698