Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2667493002: Changed EPosition to an enum class and renamed its members (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@gmail.com> 10 * Christian Biesinger <cbiesinger@gmail.com>
(...skipping 1495 matching lines...) Expand 10 before | Expand all | Expand 10 after
1506 m_resizer->setStyleWithWritingModeOfParent(std::move(resizer)); 1506 m_resizer->setStyleWithWritingModeOfParent(std::move(resizer));
1507 } else if (m_resizer) { 1507 } else if (m_resizer) {
1508 m_resizer->destroy(); 1508 m_resizer->destroy();
1509 m_resizer = nullptr; 1509 m_resizer = nullptr;
1510 } 1510 }
1511 } 1511 }
1512 1512
1513 void PaintLayerScrollableArea::invalidateAllStickyConstraints() { 1513 void PaintLayerScrollableArea::invalidateAllStickyConstraints() {
1514 if (PaintLayerScrollableAreaRareData* d = rareData()) { 1514 if (PaintLayerScrollableAreaRareData* d = rareData()) {
1515 for (PaintLayer* stickyLayer : d->m_stickyConstraintsMap.keys()) { 1515 for (PaintLayer* stickyLayer : d->m_stickyConstraintsMap.keys()) {
1516 if (stickyLayer->layoutObject()->style()->position() == StickyPosition) 1516 if (stickyLayer->layoutObject()->style()->position() ==
1517 EPosition::kSticky)
1517 stickyLayer->setNeedsCompositingInputsUpdate(); 1518 stickyLayer->setNeedsCompositingInputsUpdate();
1518 } 1519 }
1519 d->m_stickyConstraintsMap.clear(); 1520 d->m_stickyConstraintsMap.clear();
1520 } 1521 }
1521 } 1522 }
1522 1523
1523 void PaintLayerScrollableArea::invalidateStickyConstraintsFor( 1524 void PaintLayerScrollableArea::invalidateStickyConstraintsFor(
1524 PaintLayer* layer, 1525 PaintLayer* layer,
1525 bool needsCompositingUpdate) { 1526 bool needsCompositingUpdate) {
1526 if (PaintLayerScrollableAreaRareData* d = rareData()) { 1527 if (PaintLayerScrollableAreaRareData* d = rareData()) {
1527 d->m_stickyConstraintsMap.remove(layer); 1528 d->m_stickyConstraintsMap.remove(layer);
1528 if (needsCompositingUpdate && 1529 if (needsCompositingUpdate &&
1529 layer->layoutObject()->style()->position() == StickyPosition) 1530 layer->layoutObject()->style()->position() == EPosition::kSticky)
1530 layer->setNeedsCompositingInputsUpdate(); 1531 layer->setNeedsCompositingInputsUpdate();
1531 } 1532 }
1532 } 1533 }
1533 1534
1534 IntSize PaintLayerScrollableArea::offsetFromResizeCorner( 1535 IntSize PaintLayerScrollableArea::offsetFromResizeCorner(
1535 const IntPoint& absolutePoint) const { 1536 const IntPoint& absolutePoint) const {
1536 // Currently the resize corner is either the bottom right corner or the bottom 1537 // Currently the resize corner is either the bottom right corner or the bottom
1537 // left corner. 1538 // left corner.
1538 // FIXME: This assumes the location is 0, 0. Is this guaranteed to always be 1539 // FIXME: This assumes the location is 0, 0. Is this guaranteed to always be
1539 // the case? 1540 // the case?
(...skipping 561 matching lines...) Expand 10 before | Expand all | Expand 10 after
2101 2102
2102 void PaintLayerScrollableArea::DelayScrollOffsetClampScope:: 2103 void PaintLayerScrollableArea::DelayScrollOffsetClampScope::
2103 clampScrollableAreas() { 2104 clampScrollableAreas() {
2104 for (auto& scrollableArea : *s_needsClamp) 2105 for (auto& scrollableArea : *s_needsClamp)
2105 scrollableArea->clampScrollOffsetAfterOverflowChange(); 2106 scrollableArea->clampScrollOffsetAfterOverflowChange();
2106 delete s_needsClamp; 2107 delete s_needsClamp;
2107 s_needsClamp = nullptr; 2108 s_needsClamp = nullptr;
2108 } 2109 }
2109 2110
2110 } // namespace blink 2111 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698