Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 2667493002: Changed EPosition to an enum class and renamed its members (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc.
4 * All rights reserved. 4 * All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 m_hitTestCacheHits(0), 96 m_hitTestCacheHits(0),
97 m_hitTestCache(HitTestCache::create()) { 97 m_hitTestCache(HitTestCache::create()) {
98 // init LayoutObject attributes 98 // init LayoutObject attributes
99 setInline(false); 99 setInline(false);
100 100
101 m_minPreferredLogicalWidth = LayoutUnit(); 101 m_minPreferredLogicalWidth = LayoutUnit();
102 m_maxPreferredLogicalWidth = LayoutUnit(); 102 m_maxPreferredLogicalWidth = LayoutUnit();
103 103
104 setPreferredLogicalWidthsDirty(MarkOnlyThis); 104 setPreferredLogicalWidthsDirty(MarkOnlyThis);
105 105
106 setPositionState(AbsolutePosition); // to 0,0 :) 106 setPositionState(EPosition::kAbsolute); // to 0,0 :)
107 } 107 }
108 108
109 LayoutView::~LayoutView() {} 109 LayoutView::~LayoutView() {}
110 110
111 bool LayoutView::hitTest(HitTestResult& result) { 111 bool LayoutView::hitTest(HitTestResult& result) {
112 // We have to recursively update layout/style here because otherwise, when the 112 // We have to recursively update layout/style here because otherwise, when the
113 // hit test recurses into a child document, it could trigger a layout on the 113 // hit test recurses into a child document, it could trigger a layout on the
114 // parent document, which can destroy PaintLayer that are higher up in the 114 // parent document, which can destroy PaintLayer that are higher up in the
115 // call stack, leading to crashes. 115 // call stack, leading to crashes.
116 // Note that Document::updateLayout calls its parent's updateLayout. 116 // Note that Document::updateLayout calls its parent's updateLayout.
(...skipping 932 matching lines...) Expand 10 before | Expand all | Expand 10 after
1049 bool LayoutView::paintedOutputOfObjectHasNoEffectRegardlessOfSize() const { 1049 bool LayoutView::paintedOutputOfObjectHasNoEffectRegardlessOfSize() const {
1050 // Frame scroll corner is painted using LayoutView as the display item client. 1050 // Frame scroll corner is painted using LayoutView as the display item client.
1051 if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled() && 1051 if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled() &&
1052 (frameView()->horizontalScrollbar() || frameView()->verticalScrollbar())) 1052 (frameView()->horizontalScrollbar() || frameView()->verticalScrollbar()))
1053 return false; 1053 return false;
1054 1054
1055 return LayoutBlockFlow::paintedOutputOfObjectHasNoEffectRegardlessOfSize(); 1055 return LayoutBlockFlow::paintedOutputOfObjectHasNoEffectRegardlessOfSize();
1056 } 1056 }
1057 1057
1058 } // namespace blink 1058 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698