third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp - Issue 2667493002: Changed EPosition to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

Issue 2667493002: Changed EPosition to an enum class and renamed its members (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

index a496cf22535439c43d60e28b0f793e4805232293..74fefefb6a647bfc054f3798ad8fa35ded663260 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

@@ -641,7 +641,7 @@ bool PaintLayerPainter::atLeastOneFragmentIntersectsDamageRect(

inline bool PaintLayerPainter::isFixedPositionObjectInPagedMedia() {

LayoutObject* object = m_paintLayer.layoutObject();

LayoutView* view = object->view();

- return object->styleRef().position() == FixedPosition &&

+ return object->styleRef().position() == EPosition::kFixed &&

object->container() == view && view->pageLogicalHeight() &&

// TODO(crbug.com/619094): Figure out the correct behaviour for fixed

// position objects in paged media with vertical writing modes.