Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp

Issue 2667493002: Changed EPosition to an enum class and renamed its members (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/paint/PrePaintTreeWalk.h" 5 #include "core/paint/PrePaintTreeWalk.h"
6 6
7 #include "core/dom/DocumentLifecycle.h" 7 #include "core/dom/DocumentLifecycle.h"
8 #include "core/frame/FrameView.h" 8 #include "core/frame/FrameView.h"
9 #include "core/frame/LocalFrame.h" 9 #include "core/frame/LocalFrame.h"
10 #include "core/layout/LayoutMultiColumnSpannerPlaceholder.h" 10 #include "core/layout/LayoutMultiColumnSpannerPlaceholder.h"
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 PrePaintTreeWalkContext& context) { 75 PrePaintTreeWalkContext& context) {
76 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) 76 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled())
77 return; 77 return;
78 78
79 if (!object.hasLayer()) 79 if (!object.hasLayer())
80 return; 80 return;
81 81
82 PaintLayer* paintLayer = object.enclosingLayer(); 82 PaintLayer* paintLayer = object.enclosingLayer();
83 paintLayer->updateAncestorOverflowLayer(context.ancestorOverflowPaintLayer); 83 paintLayer->updateAncestorOverflowLayer(context.ancestorOverflowPaintLayer);
84 84
85 if (object.styleRef().position() == StickyPosition) { 85 if (object.styleRef().position() == EPosition::kSticky) {
86 paintLayer->layoutObject()->updateStickyPositionConstraints(); 86 paintLayer->layoutObject()->updateStickyPositionConstraints();
87 87
88 // Sticky position constraints and ancestor overflow scroller affect the 88 // Sticky position constraints and ancestor overflow scroller affect the
89 // sticky layer position, so we need to update it again here. 89 // sticky layer position, so we need to update it again here.
90 // TODO(flackr): This should be refactored in the future to be clearer (i.e. 90 // TODO(flackr): This should be refactored in the future to be clearer (i.e.
91 // update layer position and ancestor inputs updates in the same walk). 91 // update layer position and ancestor inputs updates in the same walk).
92 paintLayer->updateLayerPosition(); 92 paintLayer->updateLayerPosition();
93 } 93 }
94 94
95 if (paintLayer->isRootLayer() || object.hasOverflowClip()) 95 if (paintLayer->isRootLayer() || object.hasOverflowClip())
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
274 roundedIntPoint(context.treeBuilderContext.current.paintOffset); 274 roundedIntPoint(context.treeBuilderContext.current.paintOffset);
275 walk(*toFrameView(widget), context); 275 walk(*toFrameView(widget), context);
276 } 276 }
277 // TODO(pdr): Investigate RemoteFrameView (crbug.com/579281). 277 // TODO(pdr): Investigate RemoteFrameView (crbug.com/579281).
278 } 278 }
279 279
280 object.getMutableForPainting().clearPaintFlags(); 280 object.getMutableForPainting().clearPaintFlags();
281 } 281 }
282 282
283 } // namespace blink 283 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698