Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: third_party/WebKit/Source/web/FindInPageCoordinates.cpp

Issue 2667493002: Changed EPosition to an enum class and renamed its members (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyleConstants.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 88
89 // Make the coordinates relative to the container enclosing bounding box. 89 // Make the coordinates relative to the container enclosing bounding box.
90 // Since we work with rects enclosing quad unions this is still 90 // Since we work with rects enclosing quad unions this is still
91 // transform-friendly. 91 // transform-friendly.
92 FloatRect normalizedRect = absoluteRect; 92 FloatRect normalizedRect = absoluteRect;
93 normalizedRect.moveBy(-containerRect.location()); 93 normalizedRect.moveBy(-containerRect.location());
94 94
95 // Fixed positions do not make sense in this coordinate system, but need to 95 // Fixed positions do not make sense in this coordinate system, but need to
96 // leave consistent tickmarks. So, use their position when the view is not 96 // leave consistent tickmarks. So, use their position when the view is not
97 // scrolled, like an absolute position. 97 // scrolled, like an absolute position.
98 if (layoutObject->style()->position() == FixedPosition && 98 if (layoutObject->style()->position() == EPosition::kFixed &&
99 container->isLayoutView()) { 99 container->isLayoutView()) {
100 normalizedRect.move( 100 normalizedRect.move(
101 -toLayoutView(container)->frameView()->getScrollOffset()); 101 -toLayoutView(container)->frameView()->getScrollOffset());
102 } 102 }
103 103
104 normalizedRect.scale(1 / containerRect.width(), 1 / containerRect.height()); 104 normalizedRect.scale(1 / containerRect.width(), 1 / containerRect.height());
105 return normalizedRect; 105 return normalizedRect;
106 } 106 }
107 107
108 FloatRect findInPageRectFromAbsoluteRect(const FloatRect& inputRect, 108 FloatRect findInPageRectFromAbsoluteRect(const FloatRect& inputRect,
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 FloatRect findInPageRectFromRange(Range* range) { 146 FloatRect findInPageRectFromRange(Range* range) {
147 if (!range || !range->firstNode()) 147 if (!range || !range->firstNode())
148 return FloatRect(); 148 return FloatRect();
149 149
150 return findInPageRectFromAbsoluteRect( 150 return findInPageRectFromAbsoluteRect(
151 LayoutObject::absoluteBoundingBoxRectForRange(range), 151 LayoutObject::absoluteBoundingBoxRectForRange(range),
152 range->firstNode()->layoutObject()); 152 range->firstNode()->layoutObject());
153 } 153 }
154 154
155 } // namespace blink 155 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyleConstants.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698