third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp - Issue 2667493002: Changed EPosition to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp

Issue 2667493002: Changed EPosition to an enum class and renamed its members (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp b/third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp

index ffcc1e67dd60e60da1ce66dbaaa38de228b51dba..989d93ade5b931da4d7d54a6beb988c1c6ba09c8 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp

@@ -195,7 +195,8 @@ static bool canMapBetweenLayoutObjects(const LayoutObject* layoutObject,

for (const LayoutObject* current = layoutObject;;

current = current->parent()) {

const ComputedStyle& style = current->styleRef();

- if (style.position() == FixedPosition || style.isFlippedBlocksWritingMode())

+ if (style.position() == EPosition::kFixed ||

+ style.isFlippedBlocksWritingMode())

return false;

if (current->style()->canContainFixedPositionObjects() ||