third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc - Issue 2667493002: Changed EPosition to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

Issue 2667493002: Changed EPosition to an enum class and renamed its members (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp ('k') | third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

index 0d92903cecd8964f77c6475e0d1b1b696c4b49fb..6ba7f392a61cb070e15a86b16f09aa204da1af70 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

@@ -430,7 +430,7 @@ RefPtr<NGPhysicalFragment> NGBlockLayoutAlgorithm::Layout() {

if (current_child_->Type() == NGLayoutInputNode::kLegacyBlock) {

NGBlockNode* current_block_child = toNGBlockNode(current_child_);

EPosition position = current_block_child->Style().position();

- if (position == AbsolutePosition || position == FixedPosition) {

+ if (position == EPosition::kAbsolute || position == EPosition::kFixed) {

builder_->AddOutOfFlowChildCandidate(current_block_child,

GetChildSpaceOffset());

current_child_ = current_block_child->NextSibling();