Migrate WTF::HashSet::add() to ::insert() [part 1 of N]

Migrate WTF::HashSet::add() to ::insert() [part 1 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL fixes many (but not all) references to use insert() instead of
add(). However, there are several subclasses of HashSet which inherit
all the methods, and this CL does not attempt to change references to
those subclasses. (A future CL will do exactly that.)

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2657443005
Cr-Commit-Position: refs/heads/master@{#446215}
Committed: https://chromium.googlesource.com/chromium/src/+/a980b812f2f213270551f986fc7c4fdf0cc2d3a8

[pilgrim_google, 2017-01-25 20:35:11]

Description was changed from

==========
Migrate WTF::HashSet::add() to ::insert() [part 1 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL fixes many (but not all) references to use insert() instead of
add(). However, there are several subclasses of HashSet which inherit
all the methods, and this CL does not attempt to change references to
those subclasses. (A future CL will do exactly that.)

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
==========

to

==========
Migrate WTF::HashSet::add() to ::insert() [part 1 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL fixes many (but not all) references to use insert() instead of
add(). However, there are several subclasses of HashSet which inherit
all the methods, and this CL does not attempt to change references to
those subclasses. (A future CL will do exactly that.)

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[pilgrim_google, 2017-01-25 20:35:12]

Description was changed from

==========
Migrate WTF::HashSet::add() to ::insert() [part 1 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL fixes many (but not all) references to use insert() instead of
add(). However, there are several subclasses of HashSet which inherit
all the methods, and this CL does not attempt to change references to
those subclasses. (A future CL will do exactly that.)

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Migrate WTF::HashSet::add() to ::insert() [part 1 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL fixes many (but not all) references to use insert() instead of
add(). However, there are several subclasses of HashSet which inherit
all the methods, and this CL does not attempt to change references to
those subclasses. (A future CL will do exactly that.)

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pilgrim_google, 2017-01-25 20:36:15]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[pilgrim_google, 2017-01-25 20:36:33]

pilgrim@chromium.org changed reviewers:
+ esprehn@chromium.org, haraken@chromium.org, yutak@chromium.org

[commit-bot: I haz the power, 2017-01-25 20:36:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-01-25 20:56:26]

LGTM

[commit-bot: I haz the power, 2017-01-25 22:29:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 22:29:30]

Dry run: This issue passed the CQ dry run.

[pilgrim_google, 2017-01-26 02:48:56]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2017-01-26 02:49:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 02:59:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485398936714150, "parent_rev":
"c2ac3cdd356a0c84cf22489fdf692edcb35f5194", "commit_rev":
"a980b812f2f213270551f986fc7c4fdf0cc2d3a8"}

[commit-bot: I haz the power, 2017-01-26 03:00:21]

Description was changed from

==========
Migrate WTF::HashSet::add() to ::insert() [part 1 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL fixes many (but not all) references to use insert() instead of
add(). However, there are several subclasses of HashSet which inherit
all the methods, and this CL does not attempt to change references to
those subclasses. (A future CL will do exactly that.)

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Migrate WTF::HashSet::add() to ::insert() [part 1 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL fixes many (but not all) references to use insert() instead of
add(). However, there are several subclasses of HashSet which inherit
all the methods, and this CL does not attempt to change references to
those subclasses. (A future CL will do exactly that.)

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2657443005
Cr-Commit-Position: refs/heads/master@{#446215}
Committed:
https://chromium.googlesource.com/chromium/src/+/a980b812f2f213270551f986fc7c...
==========

[commit-bot: I haz the power, 2017-01-26 03:00:26]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a980b812f2f213270551f986fc7c...