third_party/WebKit/Source/web/tests/WebFrameTest.cpp - Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

index 25e59a6bd2fc255cf496c17dc5ddd7be58352677..cceac881f03f701b20faa4b848fe9cdef887ad1d 100644

--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

@@ -11146,7 +11146,7 @@ TEST_F(WebFrameTest, UniqueNames) {

HashSet<AtomicString> names;

for (Frame* frame = mainFrame->tree().firstChild(); frame;

frame = frame->tree().traverseNext()) {

- EXPECT_TRUE(names.add(frame->tree().uniqueName()).isNewEntry);

+ EXPECT_TRUE(names.insert(frame->tree().uniqueName()).isNewEntry);

}

EXPECT_EQ(10u, names.size());

}