Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameConsole.cpp

Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N] (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 std::unique_ptr<SourceLocation> location, 96 std::unique_ptr<SourceLocation> location,
97 const String& workerId) { 97 const String& workerId) {
98 reportMessageToClient(WorkerMessageSource, level, message, location.get()); 98 reportMessageToClient(WorkerMessageSource, level, message, location.get());
99 addMessageToStorage(ConsoleMessage::createFromWorker( 99 addMessageToStorage(ConsoleMessage::createFromWorker(
100 level, message, std::move(location), workerId)); 100 level, message, std::move(location), workerId));
101 } 101 }
102 102
103 void FrameConsole::addSingletonMessage(ConsoleMessage* consoleMessage) { 103 void FrameConsole::addSingletonMessage(ConsoleMessage* consoleMessage) {
104 if (m_singletonMessages.contains(consoleMessage->message())) 104 if (m_singletonMessages.contains(consoleMessage->message()))
105 return; 105 return;
106 m_singletonMessages.add(consoleMessage->message()); 106 m_singletonMessages.insert(consoleMessage->message());
107 addMessage(consoleMessage); 107 addMessage(consoleMessage);
108 } 108 }
109 109
110 void FrameConsole::reportResourceResponseReceived( 110 void FrameConsole::reportResourceResponseReceived(
111 DocumentLoader* loader, 111 DocumentLoader* loader,
112 unsigned long requestIdentifier, 112 unsigned long requestIdentifier,
113 const ResourceResponse& response) { 113 const ResourceResponse& response) {
114 if (!loader) 114 if (!loader)
115 return; 115 return;
116 if (response.httpStatusCode() < 400) 116 if (response.httpStatusCode() < 400)
(...skipping 23 matching lines...) Expand all
140 addMessageToStorage(ConsoleMessage::createForRequest( 140 addMessageToStorage(ConsoleMessage::createForRequest(
141 NetworkMessageSource, ErrorMessageLevel, message.toString(), 141 NetworkMessageSource, ErrorMessageLevel, message.toString(),
142 error.failingURL(), requestIdentifier)); 142 error.failingURL(), requestIdentifier));
143 } 143 }
144 144
145 DEFINE_TRACE(FrameConsole) { 145 DEFINE_TRACE(FrameConsole) {
146 visitor->trace(m_frame); 146 visitor->trace(m_frame);
147 } 147 }
148 148
149 } // namespace blink 149 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/fileapi/FileReader.cpp ('k') | third_party/WebKit/Source/core/frame/FrameSerializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698