third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp - Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

index 560cdf9049e3e82e25b1c3ec8cdf89104ace64f8..93b0508ee69d4272f808302404a08e48d5289130 100644

--- a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

+++ b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

@@ -201,7 +201,7 @@ inline CSSPrimitiveValue* zoomAdjustedPixelValue(double value,

void logUnimplementedPropertyID(CSSPropertyID propertyID) {

DEFINE_STATIC_LOCAL(HashSet<CSSPropertyID>, propertyIDSet, ());

- if (!propertyIDSet.add(propertyID).isNewEntry)

+ if (!propertyIDSet.insert(propertyID).isNewEntry)

return;

DLOG(ERROR) << "Blink does not yet implement getComputedStyle for '"