third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp - Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp

Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/CustomElementDescriptorTest.cpp ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp

index 79d0833ee1e25304810a47337e59fcbefccc983a..245c52da9a70e30750aa65b123abb30a5331af17 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp

@@ -238,7 +238,7 @@ bool CustomElementRegistry::nameIsDefined(const AtomicString& name) const {

}

void CustomElementRegistry::entangle(V0CustomElementRegistrationContext* v0) {

- m_v0->add(v0);

+ m_v0->insert(v0);

v0->setV1(this);

}

@@ -267,7 +267,7 @@ void CustomElementRegistry::addCandidate(Element* candidate) {

set = m_upgradeCandidates->add(name, new UpgradeCandidateSet())

.storedValue->value;

}

- set->add(candidate);

+ set->insert(candidate);

}

// https://html.spec.whatwg.org/multipage/scripting.html#dom-customelementsregistry-whendefined