third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp - Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXObject.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXTable.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

index a79d0b6e5c83ab862d4e0dbaf2fc29089b15cf7a..8f1db79a94782bb0cb273f41070d9477c1bd4550 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

@@ -542,7 +542,7 @@ AXID AXObjectCacheImpl::getAXID(AXObject* obj) {

objID = platformGenerateAXID();

- m_idsInUse.add(objID);

+ m_idsInUse.insert(objID);

obj->setAXObjectID(objID);

return objID;

@@ -712,7 +712,7 @@ void AXObjectCacheImpl::updateAriaOwns(

HashSet<String> newIds;

bool idsChanged = false;

for (const String& id : idVector) {

- newIds.add(id);

+ newIds.insert(id);

if (!currentIds.contains(id)) {

idsChanged = true;

HashSet<AXID>* owners = m_idToAriaOwnersMapping.get(id);

@@ -720,7 +720,7 @@ void AXObjectCacheImpl::updateAriaOwns(

owners = new HashSet<AXID>();

m_idToAriaOwnersMapping.set(id, WTF::wrapUnique(owners));

}

- owners->add(owner->axObjectID());

+ owners->insert(owner->axObjectID());

}

for (const String& id : currentIds) {