Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp

Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N] (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/dom/custom/CustomElementRegistry.h" 5 #include "core/dom/custom/CustomElementRegistry.h"
6 6
7 #include "bindings/core/v8/ExceptionState.h" 7 #include "bindings/core/v8/ExceptionState.h"
8 #include "bindings/core/v8/ScriptCustomElementDefinitionBuilder.h" 8 #include "bindings/core/v8/ScriptCustomElementDefinitionBuilder.h"
9 #include "bindings/core/v8/ScriptPromise.h" 9 #include "bindings/core/v8/ScriptPromise.h"
10 #include "bindings/core/v8/ScriptPromiseResolver.h" 10 #include "bindings/core/v8/ScriptPromiseResolver.h"
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 } 231 }
232 // 6. Return null 232 // 6. Return null
233 return nullptr; 233 return nullptr;
234 } 234 }
235 235
236 bool CustomElementRegistry::nameIsDefined(const AtomicString& name) const { 236 bool CustomElementRegistry::nameIsDefined(const AtomicString& name) const {
237 return m_definitions.contains(name); 237 return m_definitions.contains(name);
238 } 238 }
239 239
240 void CustomElementRegistry::entangle(V0CustomElementRegistrationContext* v0) { 240 void CustomElementRegistry::entangle(V0CustomElementRegistrationContext* v0) {
241 m_v0->add(v0); 241 m_v0->insert(v0);
242 v0->setV1(this); 242 v0->setV1(this);
243 } 243 }
244 244
245 bool CustomElementRegistry::v0NameIsDefined(const AtomicString& name) { 245 bool CustomElementRegistry::v0NameIsDefined(const AtomicString& name) {
246 for (const auto& v0 : *m_v0) { 246 for (const auto& v0 : *m_v0) {
247 if (v0->nameIsDefined(name)) 247 if (v0->nameIsDefined(name))
248 return true; 248 return true;
249 } 249 }
250 return false; 250 return false;
251 } 251 }
252 252
253 CustomElementDefinition* CustomElementRegistry::definitionForName( 253 CustomElementDefinition* CustomElementRegistry::definitionForName(
254 const AtomicString& name) const { 254 const AtomicString& name) const {
255 return m_definitions.get(name); 255 return m_definitions.get(name);
256 } 256 }
257 257
258 void CustomElementRegistry::addCandidate(Element* candidate) { 258 void CustomElementRegistry::addCandidate(Element* candidate) {
259 const AtomicString& name = candidate->localName(); 259 const AtomicString& name = candidate->localName();
260 if (nameIsDefined(name) || v0NameIsDefined(name)) 260 if (nameIsDefined(name) || v0NameIsDefined(name))
261 return; 261 return;
262 UpgradeCandidateMap::iterator it = m_upgradeCandidates->find(name); 262 UpgradeCandidateMap::iterator it = m_upgradeCandidates->find(name);
263 UpgradeCandidateSet* set; 263 UpgradeCandidateSet* set;
264 if (it != m_upgradeCandidates->end()) { 264 if (it != m_upgradeCandidates->end()) {
265 set = it->value; 265 set = it->value;
266 } else { 266 } else {
267 set = m_upgradeCandidates->add(name, new UpgradeCandidateSet()) 267 set = m_upgradeCandidates->add(name, new UpgradeCandidateSet())
268 .storedValue->value; 268 .storedValue->value;
269 } 269 }
270 set->add(candidate); 270 set->insert(candidate);
271 } 271 }
272 272
273 // https://html.spec.whatwg.org/multipage/scripting.html#dom-customelementsregis try-whendefined 273 // https://html.spec.whatwg.org/multipage/scripting.html#dom-customelementsregis try-whendefined
274 ScriptPromise CustomElementRegistry::whenDefined( 274 ScriptPromise CustomElementRegistry::whenDefined(
275 ScriptState* scriptState, 275 ScriptState* scriptState,
276 const AtomicString& name, 276 const AtomicString& name,
277 ExceptionState& exceptionState) { 277 ExceptionState& exceptionState) {
278 if (throwIfInvalidName(name, exceptionState)) 278 if (throwIfInvalidName(name, exceptionState))
279 return ScriptPromise(); 279 return ScriptPromise();
280 CustomElementDefinition* definition = definitionForName(name); 280 CustomElementDefinition* definition = definitionForName(name);
(...skipping 24 matching lines...) Expand all
305 m_upgradeCandidates->remove(it); 305 m_upgradeCandidates->remove(it);
306 306
307 Document* document = m_owner->document(); 307 Document* document = m_owner->document();
308 if (!document) 308 if (!document)
309 return; 309 return;
310 310
311 sorter.sorted(elements, document); 311 sorter.sorted(elements, document);
312 } 312 }
313 313
314 } // namespace blink 314 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698