Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N] (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
diff --git a/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp b/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
index 690a6ed753457603ad66e88a3258a9ef687633b6..04a0f36e006736700b07c0230de8ddb202681a6f 100644
--- a/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
+++ b/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
@@ -320,7 +320,7 @@ void ResourceFetcher::requestLoadStarted(unsigned long identifier,
if (m_validatedURLs.size() >= kMaxValidatedURLsSize) {
m_validatedURLs.clear();
}
- m_validatedURLs.add(request.resourceRequest().url());
+ m_validatedURLs.insert(request.resourceRequest().url());
}
static std::unique_ptr<TracedValue> urlForTraceEvent(const KURL& url) {
@@ -423,7 +423,7 @@ void ResourceFetcher::moveCachedNonBlockingResourceToBlocking(
m_nonBlockingLoaders.contains(resource->loader()) &&
resource->isLinkPreload() && !request.forPreload()) {
m_nonBlockingLoaders.remove(resource->loader());
- m_loaders.add(resource->loader());
+ m_loaders.insert(resource->loader());
}
}
@@ -1031,7 +1031,7 @@ void ResourceFetcher::preloadStarted(Resource* resource) {
m_preloads->add(resource);
if (m_preloadedURLsForTest)
- m_preloadedURLsForTest->add(resource->url().getString());
+ m_preloadedURLsForTest->insert(resource->url().getString());
}
void ResourceFetcher::enableIsPreloadedForTest() {
@@ -1041,7 +1041,7 @@ void ResourceFetcher::enableIsPreloadedForTest() {
if (m_preloads) {
for (const auto& resource : *m_preloads)
- m_preloadedURLsForTest->add(resource->url().getString());
+ m_preloadedURLsForTest->insert(resource->url().getString());
}
}
@@ -1185,7 +1185,7 @@ void ResourceFetcher::moveResourceLoaderToNonBlocking(ResourceLoader* loader) {
DCHECK(loader);
// TODO(yoav): Convert CHECK to DCHECK if no crash reports come in.
CHECK(m_loaders.contains(loader));
- m_nonBlockingLoaders.add(loader);
+ m_nonBlockingLoaders.insert(loader);
m_loaders.remove(loader);
}
@@ -1217,9 +1217,9 @@ bool ResourceFetcher::startLoad(Resource* resource) {
ResourceLoader* loader = ResourceLoader::create(this, resource);
if (resource->shouldBlockLoadEvent())
- m_loaders.add(loader);
+ m_loaders.insert(loader);
else
- m_nonBlockingLoaders.add(loader);
+ m_nonBlockingLoaders.insert(loader);
storePerformanceTimingInitiatorInformation(resource);
resource->setFetcherSecurityOrigin(sourceOrigin);

Powered by Google App Engine
This is Rietveld 408576698