third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp - Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp

Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp ('k') | third_party/WebKit/Source/core/css/resolver/ElementStyleResources.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp b/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp

index 7352193f5554ac5cdcc12c9335b82fd74aac97e4..8d7f8e442b4eb0dde7a265428dff85195f50c397 100644

--- a/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp

@@ -40,7 +40,7 @@ bool CSSVariableResolver::resolveFallback(CSSParserTokenRange range,

CSSVariableData* CSSVariableResolver::valueForCustomProperty(

AtomicString name) {

if (m_variablesSeen.contains(name)) {

- m_cycleStartPoints.add(name);

+ m_cycleStartPoints.insert(name);

return nullptr;

}

@@ -94,7 +94,7 @@ PassRefPtr<CSSVariableData> CSSVariableResolver::resolveCustomProperty(

bool disallowAnimationTainted = false;

bool isAnimationTainted = variableData.isAnimationTainted();

Vector<CSSParserToken> tokens;

- m_variablesSeen.add(name);

+ m_variablesSeen.insert(name);

bool success =

resolveTokenRange(variableData.tokens(), disallowAnimationTainted, tokens,

isAnimationTainted);