third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp - Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp

Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp

diff --git a/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp b/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp

index d1702a21204e661d03f793f5a1b250f39c635c0f..1ed6912aaba4e91e0379bf44331b1fabce238e2d 100644

--- a/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp

+++ b/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp

@@ -364,7 +364,7 @@ void DOMWebSocket::connect(const String& url,

// Fail if there're duplicated elements in |protocols|.

HashSet<String> visited;

for (size_t i = 0; i < protocols.size(); ++i) {

- if (!visited.add(protocols[i]).isNewEntry) {

+ if (!visited.insert(protocols[i]).isNewEntry) {

m_state = kClosed;

exceptionState.throwDOMException(

SyntaxError, "The subprotocol '" +