third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp - Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

diff --git a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

index b2d591098f92306bcfe904ef2be4d182c2da82a3..bceb03e11d6cca630f91c6af279bd1ae2e3eb847 100644

--- a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

+++ b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

@@ -134,7 +134,7 @@ void WorkerGlobalScope::registerEventListener(

V8AbstractEventListener* eventListener) {

// TODO(sof): remove once crbug.com/677654 has been diagnosed.

CHECK(&ThreadState::fromObject(this)->heap() == &ThreadState::fromObject(eventListener)->heap());

- bool newEntry = m_eventListeners.add(eventListener).isNewEntry;

+ bool newEntry = m_eventListeners.insert(eventListener).isNewEntry;

CHECK(newEntry);

}