third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.cpp - Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.cpp

Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/heap/HeapCompactTest.cpp ('k') | third_party/WebKit/Source/platform/loader/fetch/Resource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.cpp

diff --git a/third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.cpp b/third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.cpp

index e833f3547dc914d6e42b398c5314532fc5628569..a9edb4d2c56b784a08db452824fe7c9f42c066d9 100644

--- a/third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.cpp

+++ b/third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.cpp

@@ -399,7 +399,7 @@ void parseAccessControlExposeHeadersAllowList(const String& headerValue,

for (unsigned headerCount = 0; headerCount < headers.size(); headerCount++) {

String strippedHeader = headers[headerCount].stripWhiteSpace();

if (!strippedHeader.isEmpty())

- headerSet.add(strippedHeader);

+ headerSet.insert(strippedHeader);

}

@@ -412,7 +412,7 @@ void extractCorsExposedHeaderNamesList(const ResourceResponse& response,

// header.

if (response.wasFetchedViaServiceWorker()) {

for (const auto& header : response.corsExposedHeaderNames())

- headerSet.add(header);

+ headerSet.insert(header);

return;

}

parseAccessControlExposeHeadersAllowList(