third_party/WebKit/Source/core/xml/XPathPredicate.cpp - Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xml/XPathPredicate.cpp

Issue 2657443005: Migrate WTF::HashSet::add() to ::insert() [part 1 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/xml/XPathPredicate.cpp

diff --git a/third_party/WebKit/Source/core/xml/XPathPredicate.cpp b/third_party/WebKit/Source/core/xml/XPathPredicate.cpp

index 55b27b89c320f6541b7c52161d3997050943ef81..0b8137b66321d539f69daa8662538e6eb3090567 100644

--- a/third_party/WebKit/Source/core/xml/XPathPredicate.cpp

+++ b/third_party/WebKit/Source/core/xml/XPathPredicate.cpp

@@ -240,10 +240,10 @@ Value Union::evaluate(EvaluationContext& context) const {

HeapHashSet<Member<Node>> nodes;

for (const auto& node : resultSet)

- nodes.add(node);

+ nodes.insert(node);

for (const auto& node : rhsNodes) {

- if (nodes.add(node).isNewEntry)

+ if (nodes.insert(node).isNewEntry)

resultSet.append(node);

}