Remove ScopedVector from base::JSONValueConverter

Remove ScopedVector from base::JSONValueConverter

Also modifies all codes using it.

BUG=554289

[leonhsl(Using Gerrit), 2017-01-06 07:32:39]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 07:32:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 07:46:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 07:46:34]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[leonhsl(Using Gerrit), 2017-01-06 09:37:51]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 09:38:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-01-06 09:54:40]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-01-06 10:22:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 10:22:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[leonhsl(Using Gerrit), 2017-01-09 09:02:20]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 09:02:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 09:56:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 09:56:04]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2017-01-09 10:18:20]

leon.han@intel.com changed reviewers:
+ avi@chromium.org, danakj@chromium.org, davidben@chromium.org,
kinuko@chromium.org, yoshiki@chromium.org

[leonhsl(Using Gerrit), 2017-01-09 10:18:20]

yoshiki@chromium.org: Please review changes in 
  chrome/browser/chromeos/file_manager/*
  components/drive/*
  google_apis/drive/*

danakj@chromium.org: Please review changes in 
  base/json/*

davidben@chromium.org: Please review changes in 
  chrome/browser/domain_reliability/browsertest.cc
  components/domain_reliability/*
  net/cert/ct_log_response_parser.cc
  
kinuko@chromium.org: Please review changes in 
  chrome/browser/sync_file_system/drive_backend/*

avi@: For overall review.

Thanks all!

[leonhsl(Using Gerrit), 2017-01-09 10:56:12]

Patchset #1 (id:20001) has been deleted

[danakj, 2017-01-09 15:47:05]

base/ LGTM

[Avi (use Gerrit), 2017-01-09 17:18:29]

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
File
chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc
(right):

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc:421:
EXPECT_FALSE(base::ContainsKey(app_root_by_title, remote_entry->title()));
ContainsKey requires

#include "base/stl_util.h"

(Not your fault but still...)

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc
(right):

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc:322:
std::back_inserter(*entries));
Yay move to a back_inserter!

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend/folder_creator.cc (right):

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/folder_creator.cc:86:
std::make_move_iterator(file_list->mutable_items()->end()));
nit: Why not move + back_inserter like above?

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend/list_changes_task.cc (right):

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/list_changes_task.cc:83:
change_list->mutable_items()->clear();
And a move + back_inserter again...

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc
(right):

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc:176:
contents->file_trackers[i].release();
Wrapping an existing unique_ptr and then releasing it gives me the willies.

Perhaps do:

for (...
  std::unique_ptr<FileTracker>& tracker = contents->file_trackers[i];
  if (base::ContainsKey...
    reachable_trackers.push_back(std::move(tracker));
  else ...

The move will clear it out of the old pointer, and it's more clear in the code
that we're moving ownership.

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc:194:
contents->file_metadata[i].release();
Same here.

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc
(right):

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc:325:
std::make_move_iterator(new_entries->end()));
Same question here about move + back_iterator and consistency.

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
File
chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc
(right):

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc:119:
// ownership of all elements later.
This code is scaring me, because we should be enforcing ownership in the code,
and not in a comment. Can we rewrite this code so that ownership is handled in
the code?

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc:132:
});
Yikes, I see what's going on here. We're temporarily making a double-ownership
of all the entries because of the API of PopulateInitialData. We surely must be
able to do something more clever with PopulateInitialData to avoid having to do
this.

https://codereview.chromium.org/2613223002/diff/40001/components/domain_relia...
File components/domain_reliability/config_unittest.cc (right):

https://codereview.chromium.org/2613223002/diff/40001/components/domain_relia...
components/domain_reliability/config_unittest.cc:54:
config->collectors[0].reset(new GURL());
Why not

config->collectors[0] = base::MakeUnique<GURL>();

as you're MakeUniqueifying the file?

https://codereview.chromium.org/2613223002/diff/40001/components/error_page/r...
File components/error_page/renderer/net_error_helper_core.cc (right):

https://codereview.chromium.org/2613223002/diff/40001/components/error_page/r...
components/error_page/renderer/net_error_helper_core.cc:304: for
(std::vector<std::unique_ptr<NavigationCorrection>>::const_iterator it =
for (auto it = ...)?

[leonhsl(Using Gerrit), 2017-01-10 02:55:16]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 02:55:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-01-10 04:39:36]

Thanks avi@ a lot for kindly review!

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
File
chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc
(right):

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc:421:
EXPECT_FALSE(base::ContainsKey(app_root_by_title, remote_entry->title()));
On 2017/01/09 17:18:29, Avi wrote:
> ContainsKey requires
> 
> #include "base/stl_util.h"
> 
> (Not your fault but still...)

Done.

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend/folder_creator.cc (right):

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/folder_creator.cc:86:
std::make_move_iterator(file_list->mutable_items()->end()));
On 2017/01/09 17:18:29, Avi wrote:
> nit: Why not move + back_inserter like above?

Done. I was keeping the old code calling candidates.insert() here :) Also taking
this as a chance would you please let me know more about the difference between
this and 'move+back_inserter'? Thanks.

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend/list_changes_task.cc (right):

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/list_changes_task.cc:83:
change_list->mutable_items()->clear();
On 2017/01/09 17:18:29, Avi wrote:
> And a move + back_inserter again...

:)

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc
(right):

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc:176:
contents->file_trackers[i].release();
On 2017/01/09 17:18:29, Avi wrote:
> Wrapping an existing unique_ptr and then releasing it gives me the willies.
> 
> Perhaps do:
> 
> for (...
>   std::unique_ptr<FileTracker>& tracker = contents->file_trackers[i];
>   if (base::ContainsKey...
>     reachable_trackers.push_back(std::move(tracker));
>   else ...
> 
> The move will clear it out of the old pointer, and it's more clear in the code
> that we're moving ownership.

Done.

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc:194:
contents->file_metadata[i].release();
On 2017/01/09 17:18:29, Avi wrote:
> Same here.

Done.

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc
(right):

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc:325:
std::make_move_iterator(new_entries->end()));
On 2017/01/09 17:18:29, Avi wrote:
> Same question here about move + back_iterator and consistency.

Done.

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
File
chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc
(right):

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc:132:
});
On 2017/01/09 17:18:29, Avi wrote:
> Yikes, I see what's going on here. We're temporarily making a double-ownership
> of all the entries because of the API of PopulateInitialData. We surely must
be
> able to do something more clever with PopulateInitialData to avoid having to
do
> this.

Yeah I understand the concern and I also felt a little weird when I changed
here. Could I solve this concern with a follow-up CL? I'd like to make clear of
all around PopulateInitialData and revise all related codes within a single CL.

https://codereview.chromium.org/2613223002/diff/40001/components/domain_relia...
File components/domain_reliability/config_unittest.cc (right):

https://codereview.chromium.org/2613223002/diff/40001/components/domain_relia...
components/domain_reliability/config_unittest.cc:54:
config->collectors[0].reset(new GURL());
On 2017/01/09 17:18:29, Avi wrote:
> Why not
> 
> config->collectors[0] = base::MakeUnique<GURL>();
> 
> as you're MakeUniqueifying the file?

Done.

https://codereview.chromium.org/2613223002/diff/40001/components/error_page/r...
File components/error_page/renderer/net_error_helper_core.cc (right):

https://codereview.chromium.org/2613223002/diff/40001/components/error_page/r...
components/error_page/renderer/net_error_helper_core.cc:304: for
(std::vector<std::unique_ptr<NavigationCorrection>>::const_iterator it =
On 2017/01/09 17:18:29, Avi wrote:
> for (auto it = ...)?

Done.

[leonhsl(Using Gerrit), 2017-01-10 04:47:17]

leon.han@intel.com changed reviewers:
+ mmenke@chromium.org, stevenjb@chromium.org

[leonhsl(Using Gerrit), 2017-01-10 04:47:18]

mmenke@chromium.org: Please review changes in 
  components/error_page/renderer/net_error_helper_core.cc

stevenjb@chromium.org: Please review changes in 
  chrome/browser/ui/webui/chromeos/drive_internals_ui.cc

[Avi (use Gerrit), 2017-01-10 04:48:41]

lgtm

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend/folder_creator.cc (right):

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/folder_creator.cc:86:
std::make_move_iterator(file_list->mutable_items()->end()));
On 2017/01/10 04:39:36, leonhsl wrote:
> On 2017/01/09 17:18:29, Avi wrote:
> > nit: Why not move + back_inserter like above?
> 
> Done. I was keeping the old code calling candidates.insert() here :) Also
taking
> this as a chance would you please let me know more about the difference
between
> this and 'move+back_inserter'? Thanks.

They should be equivalent, though move_inserter allows you to insert anywhere
while back_inserter is only for the back and front_inserter won't work on a
vector that doesn't have push_front().

Either one is fine here; I was just wondering about consistency.

BTW I didn't know about move_iterators; thank you for teaching me.

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
File
chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc
(right):

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc:132:
});
On 2017/01/10 04:39:36, leonhsl wrote:
> On 2017/01/09 17:18:29, Avi wrote:
> > Yikes, I see what's going on here. We're temporarily making a
double-ownership
> > of all the entries because of the API of PopulateInitialData. We surely must
> be
> > able to do something more clever with PopulateInitialData to avoid having to
> do
> > this.
> 
> Yeah I understand the concern and I also felt a little weird when I changed
> here. Could I solve this concern with a follow-up CL? I'd like to make clear
of
> all around PopulateInitialData and revise all related codes within a single
CL.

:\

Can you at least put a TODO(you) there to make it clear? Please do follow up;
having two owners for a pointer is a dangerous pattern that we don't want to
keep around.

[leonhsl(Using Gerrit), 2017-01-10 04:58:01]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 04:58:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-01-10 05:00:39]

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
File
chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc
(right):

https://codereview.chromium.org/2613223002/diff/40001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc:132:
});
On 2017/01/10 04:48:40, Avi wrote:
> On 2017/01/10 04:39:36, leonhsl wrote:
> > On 2017/01/09 17:18:29, Avi wrote:
> > > Yikes, I see what's going on here. We're temporarily making a
> double-ownership
> > > of all the entries because of the API of PopulateInitialData. We surely
must
> > be
> > > able to do something more clever with PopulateInitialData to avoid having
to
> > do
> > > this.
> > 
> > Yeah I understand the concern and I also felt a little weird when I changed
> > here. Could I solve this concern with a follow-up CL? I'd like to make clear
> of
> > all around PopulateInitialData and revise all related codes within a single
> CL.
> 
> :\
> 
> Can you at least put a TODO(you) there to make it clear? Please do follow up;
> having two owners for a pointer is a dangerous pattern that we don't want to
> keep around.

Done and thank you. I'll start this work soon.

[kinuko, 2017-01-10 06:06:20]

lgtm

[leonhsl(Using Gerrit), 2017-01-10 06:22:05]

leon.han@intel.com changed reviewers:
+ rdsmith@chromium.org
- davidben@chromium.org

[leonhsl(Using Gerrit), 2017-01-10 06:22:06]

rdsmith@chromium.org: Please review changes in 
  chrome/browser/domain_reliability/browsertest.cc
  components/domain_reliability/*
  net/cert/ct_log_response_parser.cc

[leonhsl(Using Gerrit), 2017-01-10 06:23:12]

leon.han@intel.com changed reviewers:
- yoshiki@chromium.org

[commit-bot: I haz the power, 2017-01-10 06:26:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 06:26:44]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2017-01-10 06:29:31]

leon.han@intel.com changed reviewers:
+ hidehiko@chromium.org

[leonhsl(Using Gerrit), 2017-01-10 06:29:31]

hidehiko@chromium.org: Please review changes in 
  components/drive/*
  google_apis/drive/*

[hidehiko, 2017-01-10 06:44:36]

[+cc: fukino@, current File's app TL].
LGTM. Thank you for clean up!

https://codereview.chromium.org/2613223002/diff/70001/components/drive/chrome...
File components/drive/chromeos/change_list_processor.cc (right):

https://codereview.chromium.org/2613223002/diff/70001/components/drive/chrome...
components/drive/chromeos/change_list_processor.cc:74: const
std::vector<std::unique_ptr<google_apis::ChangeResource>>& items =
Could you include <vector> and <memory> ?

https://codereview.chromium.org/2613223002/diff/70001/components/drive/chrome...
File components/drive/chromeos/fake_file_system.cc (right):

https://codereview.chromium.org/2613223002/diff/70001/components/drive/chrome...
components/drive/chromeos/fake_file_system.cc:407: const
std::vector<std::unique_ptr<google_apis::FileResource>>& entries =
Ditto for include.

https://codereview.chromium.org/2613223002/diff/70001/components/drive/chrome...
File components/drive/chromeos/file_system/search_operation.cc (right):

https://codereview.chromium.org/2613223002/diff/70001/components/drive/chrome...
components/drive/chromeos/file_system/search_operation.cc:40: const
std::vector<std::unique_ptr<google_apis::FileResource>>& entries =
Ditto for include <memory>

https://codereview.chromium.org/2613223002/diff/70001/components/drive/drive_...
File components/drive/drive_app_registry.cc (right):

https://codereview.chromium.org/2613223002/diff/70001/components/drive/drive_...
components/drive/drive_app_registry.cc:24: const
std::vector<std::unique_ptr<std::string>>& selectors,
Ditto for include.

https://codereview.chromium.org/2613223002/diff/70001/components/drive/servic...
File components/drive/service/fake_drive_service.cc (right):

https://codereview.chromium.org/2613223002/diff/70001/components/drive/servic...
components/drive/service/fake_drive_service.cc:1666:
std::vector<std::unique_ptr<ChangeResource>> entries;
Ditto for <vector> and <memory>

https://codereview.chromium.org/2613223002/diff/70001/google_apis/drive/drive...
File google_apis/drive/drive_api_parser.h (right):

https://codereview.chromium.org/2613223002/diff/70001/google_apis/drive/drive...
google_apis/drive/drive_api_parser.h:18: #include "base/memory/scoped_vector.h"
Could you remove?

[leonhsl(Using Gerrit), 2017-01-10 09:47:12]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 09:47:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-01-10 09:48:13]

Uploaded ps#4, PTAnL, Thanks.

https://codereview.chromium.org/2613223002/diff/70001/components/drive/chrome...
File components/drive/chromeos/change_list_processor.cc (right):

https://codereview.chromium.org/2613223002/diff/70001/components/drive/chrome...
components/drive/chromeos/change_list_processor.cc:74: const
std::vector<std::unique_ptr<google_apis::ChangeResource>>& items =
On 2017/01/10 06:44:36, hidehiko wrote:
> Could you include <vector> and <memory> ?

Done.

https://codereview.chromium.org/2613223002/diff/70001/components/drive/chrome...
File components/drive/chromeos/fake_file_system.cc (right):

https://codereview.chromium.org/2613223002/diff/70001/components/drive/chrome...
components/drive/chromeos/fake_file_system.cc:407: const
std::vector<std::unique_ptr<google_apis::FileResource>>& entries =
On 2017/01/10 06:44:36, hidehiko wrote:
> Ditto for include.

Done.

https://codereview.chromium.org/2613223002/diff/70001/components/drive/chrome...
File components/drive/chromeos/file_system/search_operation.cc (right):

https://codereview.chromium.org/2613223002/diff/70001/components/drive/chrome...
components/drive/chromeos/file_system/search_operation.cc:40: const
std::vector<std::unique_ptr<google_apis::FileResource>>& entries =
On 2017/01/10 06:44:36, hidehiko wrote:
> Ditto for include <memory>

Done.

https://codereview.chromium.org/2613223002/diff/70001/components/drive/drive_...
File components/drive/drive_app_registry.cc (right):

https://codereview.chromium.org/2613223002/diff/70001/components/drive/drive_...
components/drive/drive_app_registry.cc:24: const
std::vector<std::unique_ptr<std::string>>& selectors,
On 2017/01/10 06:44:36, hidehiko wrote:
> Ditto for include.

Done.

https://codereview.chromium.org/2613223002/diff/70001/components/drive/servic...
File components/drive/service/fake_drive_service.cc (right):

https://codereview.chromium.org/2613223002/diff/70001/components/drive/servic...
components/drive/service/fake_drive_service.cc:1666:
std::vector<std::unique_ptr<ChangeResource>> entries;
On 2017/01/10 06:44:36, hidehiko wrote:
> Ditto for <vector> and <memory>

Done.

https://codereview.chromium.org/2613223002/diff/70001/google_apis/drive/drive...
File google_apis/drive/drive_api_parser.h (right):

https://codereview.chromium.org/2613223002/diff/70001/google_apis/drive/drive...
google_apis/drive/drive_api_parser.h:18: #include "base/memory/scoped_vector.h"
On 2017/01/10 06:44:36, hidehiko wrote:
> Could you remove?

Done.
And added '#include "base/memory/scoped_vector.h"' explicitly into
drive_api_requests.h, which was including implicitly via this file. I'll remove
ScopedVector from google_apis/ with a follow-up CL.

[commit-bot: I haz the power, 2017-01-10 11:13:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 11:13:27]

Dry run: This issue passed the CQ dry run.

[mmenke, 2017-01-10 17:19:15]

components/error_page/renderer/ LGTM

https://codereview.chromium.org/2613223002/diff/90001/components/error_page/r...
File components/error_page/renderer/net_error_helper_core.cc (right):

https://codereview.chromium.org/2613223002/diff/90001/components/error_page/r...
components/error_page/renderer/net_error_helper_core.cc:105:
std::vector<std::unique_ptr<NavigationCorrection>> corrections;
need to include <memory>

[leonhsl(Using Gerrit), 2017-01-11 11:44:19]

rdsmith@chromium.org: Please review changes in 
  chrome/browser/domain_reliability/browsertest.cc
  components/domain_reliability/*
  net/cert/ct_log_response_parser.cc

stevenjb@chromium.org: Please review changes in 
  chrome/browser/chromeos/*
  chrome/browser/ui/webui/chromeos/drive_internals_ui.cc

[stevenjb, 2017-01-11 17:03:27]

owner lgtm

[leonhsl(Using Gerrit), 2017-01-12 08:27:17]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 08:27:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-01-12 08:27:45]

https://codereview.chromium.org/2613223002/diff/90001/components/error_page/r...
File components/error_page/renderer/net_error_helper_core.cc (right):

https://codereview.chromium.org/2613223002/diff/90001/components/error_page/r...
components/error_page/renderer/net_error_helper_core.cc:105:
std::vector<std::unique_ptr<NavigationCorrection>> corrections;
On 2017/01/10 17:19:14, mmenke wrote:
> need to include <memory>

Done.

[commit-bot: I haz the power, 2017-01-12 09:34:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 09:34:13]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2017-01-13 03:26:53]

Ping rdsmith@, thanks.

[Randy Smith (Not in Mondays), 2017-01-13 16:21:51]

On 2017/01/13 03:26:53, leonhsl wrote:
> Ping rdsmith@, thanks.

Sorry, missed the initial invite.  LGTM.

[leonhsl(Using Gerrit), 2017-01-14 01:27:18]

The CQ bit was checked by leon.han@intel.com

[leonhsl(Using Gerrit), 2017-01-14 01:27:19]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
avi@chromium.org, kinuko@chromium.org, hidehiko@chromium.org,
stevenjb@chromium.org, mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2613223002/#ps110001
(title: "Rebase and address comments from mmenke@")

[commit-bot: I haz the power, 2017-01-14 01:27:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-14 02:31:26]

CQ is committing da patch.

Bot data: {"patchset_id": 110001, "attempt_start_ts": 1484357238794250,
"parent_rev": "078991c0a621513fe78bde8822c7bc9f309e688d", "commit_rev":
"cf889c78fcb8f1613c362aa1ebae9a2b0290c1a7"}

[commit-bot: I haz the power, 2017-01-14 02:37:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-14 02:37:29]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[leonhsl(Using Gerrit), 2017-01-15 07:46:22]

The CQ bit was checked by leon.han@intel.com

[commit-bot: I haz the power, 2017-01-15 07:46:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-15 07:52:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-15 07:52:57]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[leonhsl(Using Gerrit), 2017-01-15 08:00:32]

On 2017/01/14 02:37:29, commit-bot: I haz the power wrote:
> Prior attempt to commit was detected, but we were not able to check whether
the
> issue was successfully committed. Please check Git history manually and
re-check
> CQ or close this issue as needed.

Actually this CL has been committed, close now.