Remove ScopedVector from base::JSONValueConverter

chrome/browser/sync_file_system/drive_backend/list_changes_task.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync_file_system/drive_backend/list_changes_task.h"
 
 #include <stddef.h>
 #include <utility>
 #include <vector>
 
@@ skipping 57 matching lines @@
     return;
   }
 
   if (!change_list) {
     NOTREACHED();
     token->RecordLog("Got invalid change list.");
     SyncTaskManager::NotifyTaskDone(std::move(token), SYNC_STATUS_FAILED);
     return;
   }
 
-  std::vector<google_apis::ChangeResource*> changes;
-  change_list->mutable_items()->release(&changes);
-
-  change_list_.reserve(change_list_.size() + changes.size());
-  for (size_t i = 0; i < changes.size(); ++i)
-    change_list_.push_back(changes[i]);
+  change_list_.reserve(change_list_.size() +
+                       change_list->mutable_items()->size());
+  std::move(change_list->mutable_items()->begin(),
+            change_list->mutable_items()->end(),
+            std::back_inserter(change_list_));
+  change_list->mutable_items()->clear();

[Avi (use Gerrit), 2017/01/09 17:18:29]

And a move + back_inserter again...

[leonhsl(Using Gerrit), 2017/01/10 04:39:36]

:)

 
   if (!change_list->next_link().is_empty()) {
     drive_service()->GetRemainingChangeList(
         change_list->next_link(),
         base::Bind(
             &ListChangesTask::DidListChanges,
             weak_ptr_factory_.GetWeakPtr(),
             base::Passed(&token)));
     return;
   }
@@ skipping 45 matching lines @@
   return sync_context_->GetMetadataDatabase();
 }
 
 drive::DriveServiceInterface* ListChangesTask::drive_service() {
   set_used_network(true);
   return sync_context_->GetDriveService();
 }
 
 }  // namespace drive_backend
 }  // namespace sync_file_system