Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: components/domain_reliability/header.cc

Issue 2613223002: Remove ScopedVector from base::JSONValueConverter (Closed)
Patch Set: Rebase and address comments from mmenke@ Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/domain_reliability/google_configs.cc ('k') | components/domain_reliability/header_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/domain_reliability/header.cc
diff --git a/components/domain_reliability/header.cc b/components/domain_reliability/header.cc
index 1e9cb6af19f3ce35fab465fc63ed54d064b7858a..05a637961e7727d4dfd4aef38b0d262fb27d9555 100644
--- a/components/domain_reliability/header.cc
+++ b/components/domain_reliability/header.cc
@@ -7,7 +7,6 @@
#include <stdint.h>
#include <string>
-
#include "base/memory/ptr_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_tokenizer.h"
@@ -158,7 +157,7 @@ bool Unquote(const std::string& in, std::string* out) {
}
bool ParseReportUri(const std::vector<base::StringPiece> in,
- ScopedVector<GURL>* out) {
+ std::vector<std::unique_ptr<GURL>>* out) {
if (in.size() < 1u)
return false;
@@ -170,7 +169,7 @@ bool ParseReportUri(const std::vector<base::StringPiece> in,
GURL url(unquoted);
if (!url.is_valid() || !content::IsOriginSecure(url))
return false;
- out->push_back(new GURL(url));
+ out->push_back(base::MakeUnique<GURL>(url));
}
return true;
@@ -201,7 +200,7 @@ DomainReliabilityHeader::~DomainReliabilityHeader() {}
// static
std::unique_ptr<DomainReliabilityHeader> DomainReliabilityHeader::Parse(
base::StringPiece value) {
- ScopedVector<GURL> report_uri;
+ std::vector<std::unique_ptr<GURL>> report_uri;
base::TimeDelta max_age;
bool include_subdomains = false;
@@ -284,7 +283,7 @@ std::string DomainReliabilityHeader::ToString() const {
DCHECK_EQ(0, max_age_s);
} else {
string += "report-uri=";
- for (const auto* uri : config_->collectors)
+ for (const auto& uri : config_->collectors)
string += uri->spec() + " ";
// Remove trailing space.
string.erase(string.length() - 1, 1);
« no previous file with comments | « components/domain_reliability/google_configs.cc ('k') | components/domain_reliability/header_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698