Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: components/drive/chromeos/change_list_processor.cc

Issue 2613223002: Remove ScopedVector from base::JSONValueConverter (Closed)
Patch Set: Rebase and address comments from mmenke@ Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/domain_reliability/util.cc ('k') | components/drive/chromeos/fake_file_system.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/drive/chromeos/change_list_processor.cc
diff --git a/components/drive/chromeos/change_list_processor.cc b/components/drive/chromeos/change_list_processor.cc
index ab2f3bdd22b03e6ff1834e15cfcd087286ae551b..833b64f03f659cb7c47cbe9f47849425e19e31f1 100644
--- a/components/drive/chromeos/change_list_processor.cc
+++ b/components/drive/chromeos/change_list_processor.cc
@@ -5,7 +5,10 @@
#include "components/drive/chromeos/change_list_processor.h"
#include <stddef.h>
+
+#include <memory>
#include <utility>
+#include <vector>
#include "base/metrics/histogram.h"
#include "base/strings/string_number_conversions.h"
@@ -71,7 +74,8 @@ ChangeList::ChangeList() {}
ChangeList::ChangeList(const google_apis::ChangeList& change_list)
: next_url_(change_list.next_link()),
largest_changestamp_(change_list.largest_change_id()) {
- const ScopedVector<google_apis::ChangeResource>& items = change_list.items();
+ const std::vector<std::unique_ptr<google_apis::ChangeResource>>& items =
+ change_list.items();
entries_.resize(items.size());
parent_resource_ids_.resize(items.size());
size_t entries_index = 0;
@@ -90,7 +94,8 @@ ChangeList::ChangeList(const google_apis::ChangeList& change_list)
ChangeList::ChangeList(const google_apis::FileList& file_list)
: next_url_(file_list.next_link()),
largest_changestamp_(0) {
- const ScopedVector<google_apis::FileResource>& items = file_list.items();
+ const std::vector<std::unique_ptr<google_apis::FileResource>>& items =
+ file_list.items();
entries_.resize(items.size());
parent_resource_ids_.resize(items.size());
size_t entries_index = 0;
« no previous file with comments | « components/domain_reliability/util.cc ('k') | components/drive/chromeos/fake_file_system.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698