chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc - Issue 2613223002: Remove ScopedVector from base::JSONValueConverter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc

Issue 2613223002: Remove ScopedVector from base::JSONValueConverter (Closed)

Patch Set: Rebase and address comments from mmenke@ Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/register_app_task_unittest.cc ('k') | chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc

diff --git a/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc b/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc

index f578c43a8f93becd830ddcdff5f91ad1ecb04fe8..b3af159b00d085292a76997c3500af3d16c086d9 100644

--- a/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc

+++ b/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc

@@ -676,11 +676,8 @@ void RemoteToLocalSyncer::DidListFolderContent(

}

children->reserve(children->size() + file_list->items().size());

- for (ScopedVector<google_apis::FileResource>::const_iterator itr =

- file_list->items().begin();

- itr != file_list->items().end();

- ++itr) {

- children->push_back((*itr)->file_id());

+ for (const auto& file_resource : file_list->items()) {

+ children->push_back(file_resource->file_id());

}

if (!file_list->next_link().is_empty()) {