Remove ScopedVector from base::JSONValueConverter

chrome/browser/sync_file_system/drive_backend/folder_creator.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync_file_system/drive_backend/folder_creator.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "chrome/browser/sync_file_system/drive_backend/drive_backend_util.h"
@@ skipping 38 matching lines @@
     google_apis::DriveApiErrorCode error,
     std::unique_ptr<google_apis::FileResource> entry) {
   SyncStatusCode status = DriveApiErrorCodeToSyncStatusCode(error);
   if (status != SYNC_STATUS_OK) {
     callback.Run(std::string(), status);
     return;
   }
 
   drive_service_->SearchByTitle(
       title_, parent_folder_id_,
-      base::Bind(&FolderCreator::DidListFolders,
-                 weak_ptr_factory_.GetWeakPtr(), callback,
-                 base::Passed(ScopedVector<google_apis::FileResource>())));
+      base::Bind(
+          &FolderCreator::DidListFolders, weak_ptr_factory_.GetWeakPtr(),
+          callback,
+          base::Passed(
+              std::vector<std::unique_ptr<google_apis::FileResource>>())));
 }
 
 void FolderCreator::DidListFolders(
     const FileIDCallback& callback,
-    ScopedVector<google_apis::FileResource> candidates,
+    std::vector<std::unique_ptr<google_apis::FileResource>> candidates,
     google_apis::DriveApiErrorCode error,
     std::unique_ptr<google_apis::FileList> file_list) {
   SyncStatusCode status = DriveApiErrorCodeToSyncStatusCode(error);
   if (status != SYNC_STATUS_OK) {
     callback.Run(std::string(), status);
     return;
   }
 
   if (!file_list) {
     NOTREACHED();
     callback.Run(std::string(), SYNC_STATUS_FAILED);
     return;
   }
 
   candidates.reserve(candidates.size() + file_list->items().size());
-  candidates.insert(candidates.end(),
-                    file_list->items().begin(),
-                    file_list->items().end());
-  file_list->mutable_items()->weak_clear();
+  candidates.insert(candidates.end(), std::make_move_iterator(
+                                          file_list->mutable_items()->begin()),
+                    std::make_move_iterator(file_list->mutable_items()->end()));

[Avi (use Gerrit), 2017/01/09 17:18:29]

nit: Why not move + back_inserter like above?

[leonhsl(Using Gerrit), 2017/01/10 04:39:36]

Done. I was keeping the old code calling candidates.insert() here :) Also taking
this as a chance would you please let me know more about the difference between
this and 'move+back_inserter'? Thanks.

[Avi (use Gerrit), 2017/01/10 04:48:40]

They should be equivalent, though move_inserter allows you to insert anywhere
while back_inserter is only for the back and front_inserter won't work on a
vector that doesn't have push_front().

Either one is fine here; I was just wondering about consistency.

BTW I didn't know about move_iterators; thank you for teaching me.

+  file_list->mutable_items()->clear();
 
   if (!file_list->next_link().is_empty()) {
     drive_service_->GetRemainingFileList(
         file_list->next_link(),
         base::Bind(&FolderCreator::DidListFolders,
                    weak_ptr_factory_.GetWeakPtr(), callback,
                    base::Passed(&candidates)));
     return;
   }
 
@@ skipping 24 matching lines @@
   if (!metadata_database_->FindFileByFileID(file_id, nullptr)) {
     callback.Run(std::string(), SYNC_FILE_ERROR_NOT_FOUND);
     return;
   }
 
   callback.Run(file_id, status);
 }
 
 }  // namespace drive_backend
 }  // namespace sync_file_system