chrome/browser/sync_file_system/drive_backend/list_changes_task.h - Issue 2613223002: Remove ScopedVector from base::JSONValueConverter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/list_changes_task.h

Issue 2613223002: Remove ScopedVector from base::JSONValueConverter (Closed)

Patch Set: Rebase and address comments from mmenke@ Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync_file_system/drive_backend/list_changes_task.h

diff --git a/chrome/browser/sync_file_system/drive_backend/list_changes_task.h b/chrome/browser/sync_file_system/drive_backend/list_changes_task.h

index 9b47673eccafec5ee3c352246274583d014c127f..220dcddbb046faa0e8cd4cfd474f64be30c82085 100644

--- a/chrome/browser/sync_file_system/drive_backend/list_changes_task.h

+++ b/chrome/browser/sync_file_system/drive_backend/list_changes_task.h

@@ -10,7 +10,6 @@

#include <memory>

#include "base/macros.h"

-#include "base/memory/scoped_vector.h"

#include "base/memory/weak_ptr.h"

#include "chrome/browser/sync_file_system/drive_backend/sync_task.h"

#include "google_apis/drive/drive_api_error_codes.h"

@@ -50,7 +49,7 @@ class ListChangesTask : public SyncTask {

drive::DriveServiceInterface* drive_service();

SyncEngineContext* sync_context_;

- ScopedVector<google_apis::ChangeResource> change_list_;

+ std::vector<std::unique_ptr<google_apis::ChangeResource>> change_list_;

std::vector<std::string> file_ids_;