chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc - Issue 2613223002: Remove ScopedVector from base::JSONValueConverter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

Issue 2613223002: Remove ScopedVector from base::JSONValueConverter (Closed)

Patch Set: Rebase and address comments from mmenke@ Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

diff --git a/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc b/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

index 21f8af2d25053523cda6bc0a4945da4d64bee454..ebab6deb3343cfdc49b8304c44af0ec9eeaa5c3b 100644

--- a/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

+++ b/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

@@ -161,7 +161,7 @@ struct AddEntriesMessage {

TargetVolume volume;

// Entries to be added.

- ScopedVector<TestEntryInfo> entries;

+ std::vector<std::unique_ptr<TestEntryInfo>> entries;

// Registers the member information to the given converter.

static void RegisterJSONConverter(

« no previous file with comments | « base/json/json_value_converter_unittest.cc ('k') | chrome/browser/chromeos/file_manager/file_tasks_unittest.cc » ('j') | no next file with comments »