Remove ScopedVector from base::JSONValueConverter

components/drive/service/fake_drive_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/drive/service/fake_drive_service.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <utility>
@@ skipping 114 matching lines @@
   if (!change_list) {
     callback.Run(error, std::move(file_list));
     return;
   }
 
   file_list.reset(new FileList);
   file_list->set_next_link(change_list->next_link());
   for (size_t i = 0; i < change_list->items().size(); ++i) {
     const ChangeResource& entry = *change_list->items()[i];
     if (entry.file())
-      file_list->mutable_items()->push_back(new FileResource(*entry.file()));
+      file_list->mutable_items()->push_back(
+          base::MakeUnique<FileResource>(*entry.file()));
   }
   callback.Run(error, std::move(file_list));
 }
 
 bool UserHasWriteAccess(google_apis::drive::PermissionRole user_permission) {
   switch (user_permission) {
     case google_apis::drive::PERMISSION_ROLE_OWNER:
     case google_apis::drive::PERMISSION_ROLE_WRITER:
       return true;
     case google_apis::drive::PERMISSION_ROLE_READER:
@@ skipping 1509 matching lines @@
     const ChangeListCallback& callback) {
   if (offline_) {
     base::ThreadTaskRunnerHandle::Get()->PostTask(
         FROM_HERE, base::Bind(callback, DRIVE_NO_CONNECTION,
                               base::Passed(std::unique_ptr<ChangeList>())));
     return;
   }
 
   // Filter out entries per parameters like |directory_resource_id| and
   // |search_query|.
-  ScopedVector<ChangeResource> entries;
+  std::vector<std::unique_ptr<ChangeResource>> entries;

[hidehiko, 2017/01/10 06:44:36]

Ditto for <vector> and <memory>

[leonhsl(Using Gerrit), 2017/01/10 09:48:13]

Done.

   int num_entries_matched = 0;
   for (auto it = entries_.begin(); it != entries_.end(); ++it) {
     const ChangeResource& entry = it->second->change_resource;
     bool should_exclude = false;
 
     // If |directory_resource_id| is set, exclude the entry if it's not in
     // the target directory.
     if (!directory_resource_id.empty()) {
       // Get the parent resource ID of the entry.
       std::string parent_resource_id;
@@ skipping 37 matching lines @@
 
     if (!should_exclude) {
       std::unique_ptr<ChangeResource> entry_copied(new ChangeResource);
       entry_copied->set_change_id(entry.change_id());
       entry_copied->set_file_id(entry.file_id());
       entry_copied->set_deleted(entry.is_deleted());
       if (entry.file()) {
         entry_copied->set_file(base::MakeUnique<FileResource>(*entry.file()));
       }
       entry_copied->set_modification_date(entry.modification_date());
-      entries.push_back(entry_copied.release());
+      entries.push_back(std::move(entry_copied));
     }
   }
 
   std::unique_ptr<ChangeList> change_list(new ChangeList);
   if (start_changestamp > 0 && start_offset == 0) {
     change_list->set_largest_change_id(about_resource_->largest_change_id());
   }
 
   // If |max_results| is set, trim the entries if the number exceeded the max
   // results.
@@ skipping 56 matching lines @@
   NOTREACHED();
   return std::unique_ptr<BatchRequestConfiguratorInterface>();
 }
 
 void FakeDriveService::NotifyObservers() {
   for (auto& observer : change_observers_)
     observer.OnNewChangeAvailable();
 }
 
 }  // namespace drive