chrome/browser/sync_file_system/drive_backend/metadata_database_index.h - Issue 2613223002: Remove ScopedVector from base::JSONValueConverter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/metadata_database_index.h

Issue 2613223002: Remove ScopedVector from base::JSONValueConverter (Closed)

Patch Set: Rebase and address comments from mmenke@ Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/metadata_database.cc ('k') | chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/metadata_database_index.h

diff --git a/chrome/browser/sync_file_system/drive_backend/metadata_database_index.h b/chrome/browser/sync_file_system/drive_backend/metadata_database_index.h

index 5c7aa62aa883a1fa431908800fb7c3325341c532..38ff499d0e1e71497ed3988375e22ae2684a07d4 100644

--- a/chrome/browser/sync_file_system/drive_backend/metadata_database_index.h

+++ b/chrome/browser/sync_file_system/drive_backend/metadata_database_index.h

@@ -17,7 +17,6 @@

#include "base/containers/hash_tables.h"

#include "base/hash.h"

#include "base/macros.h"

-#include "base/memory/scoped_vector.h"

#include "chrome/browser/sync_file_system/drive_backend/metadata_database_index_interface.h"

#include "chrome/browser/sync_file_system/drive_backend/tracker_id_set.h"

@@ -49,8 +48,8 @@ namespace drive_backend {

struct DatabaseContents {

DatabaseContents();

~DatabaseContents();

- ScopedVector<FileMetadata> file_metadata;

- ScopedVector<FileTracker> file_trackers;

+ std::vector<std::unique_ptr<FileMetadata>> file_metadata;

+ std::vector<std::unique_ptr<FileTracker>> file_trackers;

};

// Maintains indexes of MetadataDatabase on memory.