Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Side by Side Diff: components/domain_reliability/config.h

Issue 2613223002: Remove ScopedVector from base::JSONValueConverter (Closed)
Patch Set: Rebase and address comments from mmenke@ Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/domain_reliability/beacon.cc ('k') | components/domain_reliability/config.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_DOMAIN_RELIABILITY_CONFIG_H_ 5 #ifndef COMPONENTS_DOMAIN_RELIABILITY_CONFIG_H_
6 #define COMPONENTS_DOMAIN_RELIABILITY_CONFIG_H_ 6 #define COMPONENTS_DOMAIN_RELIABILITY_CONFIG_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 24 matching lines...) Expand all
35 35
36 double GetSampleRate(bool request_successful) const; 36 double GetSampleRate(bool request_successful) const;
37 37
38 // Registers with the JSONValueConverter so it will know how to convert the 38 // Registers with the JSONValueConverter so it will know how to convert the
39 // JSON for a config into the struct. 39 // JSON for a config into the struct.
40 static void RegisterJSONConverter( 40 static void RegisterJSONConverter(
41 base::JSONValueConverter<DomainReliabilityConfig>* converter); 41 base::JSONValueConverter<DomainReliabilityConfig>* converter);
42 42
43 GURL origin; 43 GURL origin;
44 bool include_subdomains; 44 bool include_subdomains;
45 ScopedVector<GURL> collectors; 45 std::vector<std::unique_ptr<GURL>> collectors;
46 46
47 double success_sample_rate; 47 double success_sample_rate;
48 double failure_sample_rate; 48 double failure_sample_rate;
49 ScopedVector<std::string> path_prefixes; 49 std::vector<std::unique_ptr<std::string>> path_prefixes;
50 50
51 private: 51 private:
52 DISALLOW_COPY_AND_ASSIGN(DomainReliabilityConfig); 52 DISALLOW_COPY_AND_ASSIGN(DomainReliabilityConfig);
53 }; 53 };
54 54
55 } // namespace domain_reliability 55 } // namespace domain_reliability
56 56
57 #endif // COMPONENTS_DOMAIN_RELIABILITY_CONFIG_H_ 57 #endif // COMPONENTS_DOMAIN_RELIABILITY_CONFIG_H_
OLDNEW
« no previous file with comments | « components/domain_reliability/beacon.cc ('k') | components/domain_reliability/config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698