chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.h - Issue 2613223002: Remove ScopedVector from base::JSONValueConverter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.h

Issue 2613223002: Remove ScopedVector from base::JSONValueConverter (Closed)

Patch Set: Rebase and address comments from mmenke@ Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc ('k') | chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.h

diff --git a/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.h b/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.h

index e720b40e8cf796a7dd4f8e024a362805bf905e17..1fce116b3a78ed88c4efe4ce57f8f836c45d0def 100644

--- a/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.h

+++ b/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.h

@@ -12,7 +12,6 @@

#include "base/macros.h"

#include "base/memory/ref_counted.h"

-#include "base/memory/scoped_vector.h"

#include "base/memory/weak_ptr.h"

#include "chrome/browser/sync_file_system/drive_backend/sync_task.h"

#include "chrome/browser/sync_file_system/sync_callbacks.h"

@@ -106,7 +105,7 @@ class SyncEngineInitializer : public SyncTask {

int find_sync_root_retry_count_;

std::unique_ptr<MetadataDatabase> metadata_database_;

- ScopedVector<google_apis::FileResource> app_root_folders_;

+ std::vector<std::unique_ptr<google_apis::FileResource>> app_root_folders_;

int64_t largest_change_id_;

std::string root_folder_id_;