chrome/browser/domain_reliability/browsertest.cc - Issue 2613223002: Remove ScopedVector from base::JSONValueConverter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/domain_reliability/browsertest.cc

Issue 2613223002: Remove ScopedVector from base::JSONValueConverter (Closed)

Patch Set: Rebase and address comments from mmenke@ Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/domain_reliability/browsertest.cc

diff --git a/chrome/browser/domain_reliability/browsertest.cc b/chrome/browser/domain_reliability/browsertest.cc

index 1954b78c9c1e14ba79b3f3651a8854cee84c9fe8..c70aacda5af4db51e3ea7600ef86bda2e53bee2c 100644

--- a/chrome/browser/domain_reliability/browsertest.cc

+++ b/chrome/browser/domain_reliability/browsertest.cc

@@ -82,7 +82,7 @@ IN_PROC_BROWSER_TEST_F(DomainReliabilityBrowserTest, UploadAtShutdown) {

auto config = base::MakeUnique<DomainReliabilityConfig>();

config->origin = GURL("https://localhost/");

config->include_subdomains = false;

- config->collectors.push_back(new GURL(

+ config->collectors.push_back(base::MakeUnique<GURL>(

net::URLRequestFailedJob::GetMockHttpsUrl(net::ERR_IO_PENDING)));

config->success_sample_rate = 1.0;

config->failure_sample_rate = 1.0;