chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.h - Issue 2613223002: Remove ScopedVector from base::JSONValueConverter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.h

Issue 2613223002: Remove ScopedVector from base::JSONValueConverter (Closed)

Patch Set: Rebase and address comments from mmenke@ Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc ('k') | chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.h

diff --git a/chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.h b/chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.h

index 599417ec7c47111f20f4afb2af979e6702e5a535..36817aac422d7705669385d491d2595a55a3de6b 100644

--- a/chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.h

+++ b/chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.h

@@ -60,11 +60,11 @@ class FakeDriveServiceHelper {

std::string* sync_root_folder_id);

google_apis::DriveApiErrorCode ListFilesInFolder(

const std::string& folder_id,

- ScopedVector<google_apis::FileResource>* entries);

+ std::vector<std::unique_ptr<google_apis::FileResource>>* entries);

google_apis::DriveApiErrorCode SearchByTitle(

const std::string& folder_id,

const std::string& title,

- ScopedVector<google_apis::FileResource>* entries);

+ std::vector<std::unique_ptr<google_apis::FileResource>>* entries);

google_apis::DriveApiErrorCode GetFileResource(

const std::string& file_id,

@@ -83,7 +83,7 @@ class FakeDriveServiceHelper {

private:

google_apis::DriveApiErrorCode CompleteListing(

std::unique_ptr<google_apis::FileList> list,

- ScopedVector<google_apis::FileResource>* entries);

+ std::vector<std::unique_ptr<google_apis::FileResource>>* entries);

void Initialize();